You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zentol (via GitHub)" <gi...@apache.org> on 2023/08/08 08:35:27 UTC

[GitHub] [flink] zentol commented on a diff in pull request #22048: [FLINK-31268][metrics] Change not to initialize operator coordinator metric group lazily

zentol commented on code in PR #22048:
URL: https://github.com/apache/flink/pull/22048#discussion_r1286794557


##########
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java:
##########
@@ -519,17 +506,24 @@ static OperatorCoordinatorHolder create(
             final int operatorMaxParallelism,
             final SubtaskAccess.SubtaskAccessFactory taskAccesses,
             final boolean supportsConcurrentExecutionAttempts,
-            final TaskInformation taskInformation)
+            final TaskInformation taskInformation,
+            final JobManagerJobMetricGroup jobManagerJobMetricGroup)
             throws Exception {
-
+        JobManagerOperatorMetricGroup parentMetricGroup =

Review Comment:
   ```suggestion
           final MetricGroup parentMetricGroup =
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org