You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2019/08/02 08:08:30 UTC

[GitHub] [incubator-weex] wrmswindmill commented on a change in pull request #2731: Add Lint in TravisCI and Update iOS TravisCI

wrmswindmill commented on a change in pull request #2731: Add Lint in TravisCI and Update iOS TravisCI
URL: https://github.com/apache/incubator-weex/pull/2731#discussion_r310024510
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -25,29 +28,63 @@ matrix:
             - android-26
             - extra-android-m2repository
       - env: TEST_SUITE=android ABI=x86
+        language: android
+        dist: trusty
+        jdk: oraclejdk8
+        android:
+          components:
+            - android-26
+            - extra-android-m2repository 
+      # static check
+      - env: TEST_SUITE=static_code_analysis OCLINT=true
+        osx_image: xcode7.2
+        language: objective-c
+      - env: TEST_SUITE=static_code_analysis ANDROID_LINT=true
         language: android
         dist: trusty
         jdk: oraclejdk8
         android:
           components:
             - android-26
             - extra-android-m2repository
+        
 cache:
   directories:
     - npm
     - $HOME/.gradle/caches/
     - $HOME/.gradle/wrapper/
     - $HOME/.android/build-cache
     - $HOME/android-ndk-r18b
+    - bundle
+
 before_cache:
   - rm -f  $HOME/.gradle/caches/modules-2/modules-2.lock
   - rm -fr $HOME/.gradle/caches/*/plugin-resolution/
+  - rm -fr $HOME/node_modules/*
+
+before_install:
+  - |
+    # install android lint 
+    if [[ ("$TEST_SUITE" = "static_code_analysis") && ("${ANDROID_LINT}" = "true") ]]; then
+      sudo apt-get install rubygems
 
 Review comment:
   not need su privilege on the Travis, the user has root privilege in default.
   I will update it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services