You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/27 17:08:00 UTC
[jira] [Commented] (SAMZA-1919) Add KafkaSystemDescriptor
constructor to allow arbitrary factory class
[ https://issues.apache.org/jira/browse/SAMZA-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630741#comment-16630741 ]
ASF GitHub Bot commented on SAMZA-1919:
---------------------------------------
GitHub user lindong28 opened a pull request:
https://github.com/apache/samza/pull/668
SAMZA-1919; Add KafkaSystemDescriptor constructor to allow arbitrary factory class
Currently KafkaSystemDescriptor is hardcoded to use org.apache.samza.system.kafka.KafkaSystemFactory as the system factory for instantiating producer/consumer/admin. Users may want to use most methods in KafkaSystemDescriptor but with a different factory class. We can meet such use-case by adding a constructor that allows user to specify the factory class name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lindong28/samza SAMZA-1919
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/668.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #668
----
commit 5431fc9f79c9d99479939a5a179616ac279ddd79
Author: Dong Lin <li...@...>
Date: 2018-09-27T16:59:50Z
SAMZA-1919; Add KafkaSystemDescriptor constructor to allow arbitrary factory class
----
> Add KafkaSystemDescriptor constructor to allow arbitrary factory class
> ----------------------------------------------------------------------
>
> Key: SAMZA-1919
> URL: https://issues.apache.org/jira/browse/SAMZA-1919
> Project: Samza
> Issue Type: Improvement
> Reporter: Dong Lin
> Assignee: Dong Lin
> Priority: Major
>
> Currently KafkaSystemDescriptor is hardcoded to use org.apache.samza.system.kafka.KafkaSystemFactory as the system factory for instantiating producer/consumer/admin. Users may want to use most methods in KafkaSystemDescriptor but with a different factory class. We can meet such use-case by adding a constructor that allows user to specify the factory class name.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)