You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "huciaa (via GitHub)" <gi...@apache.org> on 2023/10/31 20:45:25 UTC
[PR] Fix the variable name in the docs - testing_pyspark.ipynb [spark]
huciaa opened a new pull request, #43610:
URL: https://github.com/apache/spark/pull/43610
### What changes were proposed in this pull request?
I'm changing a variable name in one of the cells in the documentation regarding pyspark testing.
### Why are the changes needed?
Currently the code won't run. This simple fix will make the code in the documenatatnion usable.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
I tested this code loccally with pytest and pyspark 3.5.0
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS]Fix the variable name in the docs - testing_pyspark.ipynb [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43610:
URL: https://github.com/apache/spark/pull/43610#issuecomment-1788177955
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS]Fix the variable name in the docs - testing_pyspark.ipynb [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43610: [MINOR][DOCS]Fix the variable name in the docs - testing_pyspark.ipynb
URL: https://github.com/apache/spark/pull/43610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS]Fix the variable name in the docs - testing_pyspark.ipynb [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43610:
URL: https://github.com/apache/spark/pull/43610#issuecomment-1788126781
cc @asl3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS]Fix the variable name in the docs - testing_pyspark.ipynb [spark]
Posted by "asl3 (via GitHub)" <gi...@apache.org>.
asl3 commented on PR #43610:
URL: https://github.com/apache/spark/pull/43610#issuecomment-1788153546
thanks for the fix! LGTM
@huciaa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org