You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2014/10/16 03:03:17 UTC
Review Request 26791: Properly qualify process::Failure() in
posix.hpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26791/
-----------------------------------------------------------
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
Description
-------
To fix compilation problems when compiling files that include
<slave/containerizer/isolators/posix.hpp> without doing
"using process::Failure".
Diffs
-----
src/slave/containerizer/isolators/posix.hpp f120aafef96343d84f93c5636484509dc972a0a8
Diff: https://reviews.apache.org/r/26791/diff/
Testing
-------
make check.
Thanks,
Kapil Arya
Re: Review Request 26791: Properly qualify process::Failure() in
posix.hpp.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26791/#review56852
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 15, 2014, 6:03 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26791/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 6:03 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> To fix compilation problems when compiling files that include
> <slave/containerizer/isolators/posix.hpp> without doing
> "using process::Failure".
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/posix.hpp f120aafef96343d84f93c5636484509dc972a0a8
>
> Diff: https://reviews.apache.org/r/26791/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26791: Properly qualify process::Failure() in
posix.hpp.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26791/#review56887
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26791]
All tests passed.
- Mesos ReviewBot
On Oct. 16, 2014, 1:03 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26791/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 1:03 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> To fix compilation problems when compiling files that include
> <slave/containerizer/isolators/posix.hpp> without doing
> "using process::Failure".
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/posix.hpp f120aafef96343d84f93c5636484509dc972a0a8
>
> Diff: https://reviews.apache.org/r/26791/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Kapil Arya
>
>