You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2023/03/11 20:18:09 UTC
[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #253: [MENFORCER-469] Fix banTransitiveDependencies and transitive dependen…
slawekjaranowski opened a new pull request, #253:
URL: https://github.com/apache/maven-enforcer/pull/253
…cies with another version than the resolved one
---
- rename ResolveUtil to ResolverUtil
- introduce methods:
- resolveTransitiveDependenciesVerbose resolve with full tree contains all dependencies - also conflicted
- resolveTransitiveDependencies resolve final tree contains dependencies after conflict resolved
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #253: [MENFORCER-469] Fix banTransitiveDependencies and transitive dependen…
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #253:
URL: https://github.com/apache/maven-enforcer/pull/253#discussion_r1134504453
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/ResolveUtil.java:
##########
@@ -66,6 +62,24 @@ class ResolveUtil {
this.session = Objects.requireNonNull(session);
}
+ /**
+ * Retrieves the {@link DependencyNode} instance containing the result of the transitive dependency
Review Comment:
So ... can you propose description of this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] elharo commented on a diff in pull request #253: [MENFORCER-469] Fix banTransitiveDependencies and transitive dependen…
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #253:
URL: https://github.com/apache/maven-enforcer/pull/253#discussion_r1133782822
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/ResolveUtil.java:
##########
@@ -66,6 +62,24 @@ class ResolveUtil {
this.session = Objects.requireNonNull(session);
}
+ /**
+ * Retrieves the {@link DependencyNode} instance containing the result of the transitive dependency
Review Comment:
Please rewrite to clarify this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #253: [MENFORCER-469] Fix banTransitiveDependencies and transitive dependen…
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #253:
URL: https://github.com/apache/maven-enforcer/pull/253#discussion_r1134483476
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/ResolveUtil.java:
##########
@@ -66,6 +62,24 @@ class ResolveUtil {
this.session = Objects.requireNonNull(session);
}
+ /**
+ * Retrieves the {@link DependencyNode} instance containing the result of the transitive dependency
Review Comment:
please look at next lines - there is:
```
Retrieves the {@link DependencyNode} instance containing the result of the transitive dependency
for the current {@link MavenProject} in verbose mode.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] elharo commented on a diff in pull request #253: [MENFORCER-469] Fix banTransitiveDependencies and transitive dependen…
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #253:
URL: https://github.com/apache/maven-enforcer/pull/253#discussion_r1133299571
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/ResolveUtil.java:
##########
@@ -66,6 +62,24 @@ class ResolveUtil {
this.session = Objects.requireNonNull(session);
}
+ /**
+ * Retrieves the {@link DependencyNode} instance containing the result of the transitive dependency
Review Comment:
I'm not sure what "the result of the transitive dependency" is exactly. Is this just the transitive dependencies of the current maven project? Consider rephrasing.
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/ResolveUtil.java:
##########
@@ -66,6 +62,24 @@ class ResolveUtil {
this.session = Objects.requireNonNull(session);
}
+ /**
+ * Retrieves the {@link DependencyNode} instance containing the result of the transitive dependency
+ * for the current {@link MavenProject} in verbose mode.
+ * <p>
+ * In verbose mode all nodes participating in a conflict are retained.
+ * </p>
+ * <p>
+ * Please consult {@link ConflictResolver} and {@link DependencyManagerUtils}>
+ * /p>
Review Comment:
`</p>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #253: [MENFORCER-469] Fix banTransitiveDependencies and transitive dependen…
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #253:
URL: https://github.com/apache/maven-enforcer/pull/253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] elharo commented on a diff in pull request #253: [MENFORCER-469] Fix banTransitiveDependencies and transitive dependen…
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #253:
URL: https://github.com/apache/maven-enforcer/pull/253#discussion_r1134501189
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/ResolveUtil.java:
##########
@@ -66,6 +62,24 @@ class ResolveUtil {
this.session = Objects.requireNonNull(session);
}
+ /**
+ * Retrieves the {@link DependencyNode} instance containing the result of the transitive dependency
Review Comment:
"the result of the transitive dependency" is unclear. Transitive dependencies are not process and wouldn't normally be thought of as having results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #253: [MENFORCER-469] Fix banTransitiveDependencies and transitive dependen…
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #253:
URL: https://github.com/apache/maven-enforcer/pull/253#discussion_r1133600004
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/ResolveUtil.java:
##########
@@ -66,6 +62,24 @@ class ResolveUtil {
this.session = Objects.requireNonNull(session);
}
+ /**
+ * Retrieves the {@link DependencyNode} instance containing the result of the transitive dependency
Review Comment:
Yes it is for current maven project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org