You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by sureshms <gi...@git.apache.org> on 2015/10/30 21:39:46 UTC
[GitHub] storm pull request: STORM-1153 Use static final instead of just st...
GitHub user sureshms opened a pull request:
https://github.com/apache/storm/pull/837
STORM-1153 Use static final instead of just static for class members
Along with making static variables, I have also cleaned up the code in those files. Especially around reducing code verbosity by using Generic Type Inference.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sureshms/incubator-storm STORM-1153
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/837.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #837
----
commit 1ef7f3dceddff566de6c61d7bb619702e459e230
Author: Suresh Srinivas <su...@yahoo-inc.com>
Date: 2015-10-30T20:38:07Z
STORM-1153 Use static final instead of just static for class members
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1153 Use static final instead of just st...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/837#issuecomment-154505031
@harshach I am not concerned about it. The change is good and I assumed you had giving it a +1 just simply by checking it in. I just wanted to be sure things got cleaned up and @sureshms got credit for his work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1153 Use static final instead of just st...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/837#issuecomment-154503694
@harshach I just noticed that this has already been merged in, but the JIRA was not closed and this pull request was also not closed, there also was no vote on it. Could you resolve the JIRA and see if you can find a way to close this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1153 Use static final instead of just st...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/837#issuecomment-154504341
@revans2 Sorry. I thought I already gave my +1 on this. Not sure why the PR isn't closed. retroactive +1 on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1153 Use static final instead of just st...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/837#issuecomment-154500817
+1 the changes look good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1153 Use static final instead of just st...
Posted by sureshms <gi...@git.apache.org>.
Github user sureshms closed the pull request at:
https://github.com/apache/storm/pull/837
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1153 Use static final instead of just st...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/837#issuecomment-154504538
@sureshms can you please close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---