You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/02/11 10:25:21 UTC
[GitHub] [cordova-common] WuglyakBolgoink opened a new pull request #157: fix: doc.find is not a function
WuglyakBolgoink opened a new pull request #157:
URL: https://github.com/apache/cordova-common/pull/157
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
cordova-ios
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Closes #156
### Description
<!-- Describe your changes in detail -->
added try/catch block and return a property, because doc in this case an object and doc.find throw an error
### Testing
<!-- Please describe in detail how you tested your changes. -->
fixed on global package and reinstall cordova-ios and did cordova prepare -> result no doc.find erros.
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] raphinesse commented on pull request #157: fix(ios): doc.find is not a function
Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #157:
URL: https://github.com/apache/cordova-common/pull/157#issuecomment-777749957
Hi, thanks for taking the time to contribute a fix.
> added try/catch block and return a property, because doc in this case an object and doc.find throw an error
Could you explain why we would receive anything other than an Elementtree document instance as `doc`? I am pretty sure that this is not supposed to be happening. And if it was, the bug would be elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] WuglyakBolgoink edited a comment on pull request #157: fix(ios): doc.find is not a function
Posted by GitBox <gi...@apache.org>.
WuglyakBolgoink edited a comment on pull request #157:
URL: https://github.com/apache/cordova-common/pull/157#issuecomment-777759322
@raphinesse
> I am pretty sure that this is not supposed to be happening.
correct, but this problem was since v5.x version... I forgot to notify about this...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] raphinesse closed pull request #157: fix(ios): doc.find is not a function
Posted by GitBox <gi...@apache.org>.
raphinesse closed pull request #157:
URL: https://github.com/apache/cordova-common/pull/157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] WuglyakBolgoink commented on pull request #157: fix(ios): doc.find is not a function
Posted by GitBox <gi...@apache.org>.
WuglyakBolgoink commented on pull request #157:
URL: https://github.com/apache/cordova-common/pull/157#issuecomment-777759322
@raphinesse
> I am pretty sure that this is not supposed to be happening.
correct, but this problem was since v5.x version... I forgot to notify about this...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org