You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/07 08:09:58 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request, #7544: boards: arm: Fix the CI build errors

masayuki2009 opened a new pull request, #7544:
URL: https://github.com/apache/incubator-nuttx/pull/7544

   ## Summary
   
   - This commit fixes the CI build errors regressed by https://github.com/apache/incubator-nuttx/pull/7351
   
   ## Impact
   
   - None
   
   ## Testing
   
   - Build only
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7544: boards: arm: Fix the CI build errors

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7544:
URL: https://github.com/apache/incubator-nuttx/pull/7544#issuecomment-1305407164

   >@xiaoxiang781216
   >
   >Hmm, another error happened.
   >Should we remove CONFIG_NSH_TELNET=y from the defconfig?
   
   Perhaps, we need to add `CONFIG_SYSTEM_TELNETD=y` to the defconfig.
   Is it correct?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7544: boards: arm: Fix the CI build errors

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7544:
URL: https://github.com/apache/incubator-nuttx/pull/7544#issuecomment-1305273872

   @masayuki2009 do you recommend to merge directly or wait CI to finish?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7544: boards: arm: Fix the CI build errors

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7544:
URL: https://github.com/apache/incubator-nuttx/pull/7544#issuecomment-1305282160

   ```
   ====================================================================================
   Configuration/Tool: shenzhou/nxwm,CONFIG_ARM_TOOLCHAIN_GNU_EABI
   ------------------------------------------------------------------------------------
     Cleaning...
     Configuring...
     Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
     Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
     Building NuttX...
     Normalize shenzhou/nxwm
   123d122
   < CONFIG_SYSTEM_TELNETD_STACKSIZE=1596
   124a124
   > CONFIG_SYSTEM_TELNETD_STACKSIZE=1596
   Saving the new configuration file
   HEAD detached at pull/7544/merge
   Changes not staged for commit:
     (use "git add <file>..." to update what will be committed)
     (use "git restore <file>..." to discard changes in working directory)
   	modified:   boards/arm/stm32/shenzhou/configs/nxwm/defconfig
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7544: boards: arm: Fix the CI build errors

Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #7544:
URL: https://github.com/apache/incubator-nuttx/pull/7544


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7544: boards: arm: Fix the CI build errors

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7544:
URL: https://github.com/apache/incubator-nuttx/pull/7544#issuecomment-1305307010

   >@masayuki2009 do you recommend to merge directly or wait CI to finish?
   
   @pkarashchenko 
   Let's wait for the CI to finish.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7544: boards: arm: Fix the CI build errors

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7544:
URL: https://github.com/apache/incubator-nuttx/pull/7544#issuecomment-1305401511

   @xiaoxiang781216 
   
   Hmm, another error happened.
   Should we remove `CONFIG_NSH_TELNET=y` from the defconfig?
   
   
   ```
   ====================================================================================
   Configuration/Tool: esp32-devkitc/coex
   ------------------------------------------------------------------------------------
     Cleaning...
     Configuring...
     Building NuttX...
     % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                    Dload  Upload   Total   Spent    Left  Speed
   
     0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
     0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
     % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                    Dload  Upload   Total   Spent    Left  Speed
   
     0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
     0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
   
   100  496k  100  496k    0     0  1993k      0 --:--:-- --:--:-- --:--:-- 1993k
   
   100 1132k    0 1132k    0     0  1976k      0 --:--:-- --:--:-- --:--:-- 1976k
   100 5149k    0 5149k    0     0  3222k      0 --:--:--  0:00:01 --:--:-- 3918k
   100 5749k    0 5749k    0     0  2174k      0 --:--:--  0:00:02 --:--:-- 2229k
   100 9992k    0 9992k    0     0  3699k      0 --:--:--  0:00:02 --:--:-- 4165k
     Normalize esp32-devkitc/coex
   122d121
   < CONFIG_NSH_TELNET=y
   Saving the new configuration file
   HEAD detached at pull/7544/merge
   Changes not staged for commit:
     (use "git add <file>..." to update what will be committed)
     (use "git restore <file>..." to discard changes in working directory)
   	modified:   boards/xtensa/esp32/esp32-devkitc/configs/coex/defconfig
   
   no changes added to commit (use "git add" and/or "git commit -a")
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7544: boards: arm: Fix the CI build errors

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7544:
URL: https://github.com/apache/incubator-nuttx/pull/7544#issuecomment-1305555900

   @masayuki2009 thanks for fixing my regression.
   
   > > @xiaoxiang781216
   > > Hmm, another error happened.
   > > Should we remove CONFIG_NSH_TELNET=y from the defconfig?
   > 
   > Perhaps, we need to add `CONFIG_SYSTEM_TELNETD=y` to the defconfig. Is it correct?
   
   CONFIG_SYSTEM_TELNETD is enabled by default except DEFAULT_SMALL enable:
   https://github.com/apache/incubator-nuttx-apps/blob/master/system/telnetd/Kconfig#L8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org