You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "a-agmon (via GitHub)" <gi...@apache.org> on 2024/09/26 21:10:43 UTC
[PR] making table provider pub [iceberg-rust]
a-agmon opened a new pull request, #650:
URL: https://github.com/apache/iceberg-rust/pull/650
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat (datafusion): making IcebergTableProvider public to be used without a catalog [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 merged PR #650:
URL: https://github.com/apache/iceberg-rust/pull/650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat (datafusion): making IcebergTableProvider public to be used without a catalog [iceberg-rust]
Posted by "a-agmon (via GitHub)" <gi...@apache.org>.
a-agmon commented on PR #650:
URL: https://github.com/apache/iceberg-rust/pull/650#issuecomment-2378294205
Thanks @manuzhang ,
I will also add an integration test to cover this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat (datafusion): making IcebergTableProvider public to be used without a catalog [iceberg-rust]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #650:
URL: https://github.com/apache/iceberg-rust/pull/650#issuecomment-2378277977
Not familiar with rust, but do we have tests for such changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat (datafusion): making IcebergTableProvider public to be used without a catalog [iceberg-rust]
Posted by "a-agmon (via GitHub)" <gi...@apache.org>.
a-agmon commented on PR #650:
URL: https://github.com/apache/iceberg-rust/pull/650#issuecomment-2378363853
Thanks again @manuzhang.
@liurenjie1024 - please see this PR adding UT to this usage - creating a table provider from metadata file
https://github.com/apache/iceberg-rust/pull/651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat (datafusion): making IcebergTableProvider public to be used without a catalog [iceberg-rust]
Posted by "a-agmon (via GitHub)" <gi...@apache.org>.
a-agmon commented on code in PR #650:
URL: https://github.com/apache/iceberg-rust/pull/650#discussion_r1777960263
##########
crates/integrations/datafusion/src/table.rs:
##########
@@ -56,6 +56,13 @@ impl IcebergTableProvider {
Ok(IcebergTableProvider { table, schema })
}
+
+ /// Asynchronously tries to construct a new [`IcebergTableProvider`]
+ /// using the given table. Can be used to create a table provider from an existing table regardless of the catalog implementation.
+ pub async fn try_new_from_table(table: Table) -> Result<Self> {
Review Comment:
Sure. Will submit a PR that covers this in a few minutes.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat (datafusion): making IcebergTableProvider public to be used without a catalog [iceberg-rust]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #650:
URL: https://github.com/apache/iceberg-rust/pull/650#discussion_r1777943490
##########
crates/integrations/datafusion/src/table.rs:
##########
@@ -56,6 +56,13 @@ impl IcebergTableProvider {
Ok(IcebergTableProvider { table, schema })
}
+
+ /// Asynchronously tries to construct a new [`IcebergTableProvider`]
+ /// using the given table. Can be used to create a table provider from an existing table regardless of the catalog implementation.
+ pub async fn try_new_from_table(table: Table) -> Result<Self> {
Review Comment:
@a-agmon Specifically for usage of this API a UT is needed, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat (datafusion): making IcebergTableProvider public to be used without a catalog [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #650:
URL: https://github.com/apache/iceberg-rust/pull/650#issuecomment-2378289659
> Not familiar with rust, but do we have tests for such changes?
Good point, this is mostly an access modifier change, and other parts are already covered by test, so generally LGTM. But it would be better to have some tests to cover the usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org