You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/14 10:47:09 UTC
[GitHub] [doris] zhangstar333 opened a new pull request, #13381: [Fix](agg) fix bitmap agg core dump when phmap pointer assert alignment
zhangstar333 opened a new pull request, #13381:
URL: https://github.com/apache/doris/pull/13381
# Proposed changes
Issue Number: close #13380
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring commented on a diff in pull request #13381: [Fix](agg) fix bitmap agg core dump when phmap pointer assert alignment
Posted by GitBox <gi...@apache.org>.
dataroaring commented on code in PR #13381:
URL: https://github.com/apache/doris/pull/13381#discussion_r995665586
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -459,6 +459,7 @@ Status AggregationNode::open(RuntimeState* state) {
// this could cause unable to get JVM
if (_probe_expr_ctxs.empty()) {
_create_agg_status(_agg_data.without_key);
+ _agg_data_created_without_key = true;
Review Comment:
Could we use _probe_expr_ctxs.empty() as indicator, and do not introduce a new variable _agg_data_created_without_key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #13381: [Fix](agg) fix bitmap agg core dump when phmap pointer assert alignment
Posted by GitBox <gi...@apache.org>.
yiguolei commented on PR #13381:
URL: https://github.com/apache/doris/pull/13381#issuecomment-1289948872
1.1 not has this problem. Remove tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13381: [Fix](agg) fix bitmap agg core dump when phmap pointer assert alignment
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13381:
URL: https://github.com/apache/doris/pull/13381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13381: [Fix](agg) fix bitmap agg core dump when phmap pointer assert alignment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13381:
URL: https://github.com/apache/doris/pull/13381#issuecomment-1279109081
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13381: [Fix](agg) fix bitmap agg core dump when phmap pointer assert alignment
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13381:
URL: https://github.com/apache/doris/pull/13381#issuecomment-1279384736
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221015033545_clickbench_pr_29540.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org