You are viewing a plain text version of this content. The canonical link for it is here.
Posted to submarine-dev@hadoop.apache.org by Wei-Chiu Chuang <we...@apache.org> on 2019/09/27 20:32:36 UTC
[SUBMARINE] Please allow proper time for others to participate
Hi,
I noticed that some non-trivial PRs are committed within hours. As an
Example <https://github.com/apache/hadoop-submarine/pull/17>, this PR
implements a new set of APIs, and was committed in just 3 hours.
While I understand the desire to move the project quickly, please realize
that Apache contributors are global, in all time zones, and we should
strive to be more inclusive. By not allowing sufficient time for others to
participate, we exclude people from a different time zone from contributing
to this project. We won't be able to grow this community.
A usual practice within the Hadoop community is to +1, and then delay the
commit by 24 hours for a sizable change. I've also seen people delaying the
commit by several days for a controversial change. Trivial changes such as
typo or doc update doesn't need to respect this convention though.
Thoughts?
Best,
Wei-Chiu
Re: [SUBMARINE] Please allow proper time for others to participate
Posted by kevin su <pi...@gmail.com>.
+1 it could let more people join community
BR,
Kevin Su
Wanqiang Ji <wa...@gmail.com> 於 2019年9月28日 週六 下午12:07寫道:
> +1 It's important to grow this community.
>
> BR,
> Wanqiang Ji
>
> On Sat, Sep 28, 2019 at 4:45 AM Wangda Tan <wh...@gmail.com> wrote:
>
> > Sounds good to me.
> >
> > On Fri, Sep 27, 2019 at 1:33 PM Wei-Chiu Chuang <we...@apache.org>
> > wrote:
> >
> > > Hi,
> > > I noticed that some non-trivial PRs are committed within hours. As an
> > > Example <https://github.com/apache/hadoop-submarine/pull/17>, this PR
> > > implements a new set of APIs, and was committed in just 3 hours.
> > >
> > > While I understand the desire to move the project quickly, please
> realize
> > > that Apache contributors are global, in all time zones, and we should
> > > strive to be more inclusive. By not allowing sufficient time for others
> > to
> > > participate, we exclude people from a different time zone from
> > contributing
> > > to this project. We won't be able to grow this community.
> > >
> > > A usual practice within the Hadoop community is to +1, and then delay
> the
> > > commit by 24 hours for a sizable change. I've also seen people delaying
> > the
> > > commit by several days for a controversial change. Trivial changes such
> > as
> > > typo or doc update doesn't need to respect this convention though.
> > >
> > > Thoughts?
> > >
> > > Best,
> > > Wei-Chiu
> > >
> > --
> > Sent from Gmail Mobile
> >
>
Re: [SUBMARINE] Please allow proper time for others to participate
Posted by Wanqiang Ji <wa...@gmail.com>.
+1 It's important to grow this community.
BR,
Wanqiang Ji
On Sat, Sep 28, 2019 at 4:45 AM Wangda Tan <wh...@gmail.com> wrote:
> Sounds good to me.
>
> On Fri, Sep 27, 2019 at 1:33 PM Wei-Chiu Chuang <we...@apache.org>
> wrote:
>
> > Hi,
> > I noticed that some non-trivial PRs are committed within hours. As an
> > Example <https://github.com/apache/hadoop-submarine/pull/17>, this PR
> > implements a new set of APIs, and was committed in just 3 hours.
> >
> > While I understand the desire to move the project quickly, please realize
> > that Apache contributors are global, in all time zones, and we should
> > strive to be more inclusive. By not allowing sufficient time for others
> to
> > participate, we exclude people from a different time zone from
> contributing
> > to this project. We won't be able to grow this community.
> >
> > A usual practice within the Hadoop community is to +1, and then delay the
> > commit by 24 hours for a sizable change. I've also seen people delaying
> the
> > commit by several days for a controversial change. Trivial changes such
> as
> > typo or doc update doesn't need to respect this convention though.
> >
> > Thoughts?
> >
> > Best,
> > Wei-Chiu
> >
> --
> Sent from Gmail Mobile
>
Re: [SUBMARINE] Please allow proper time for others to participate
Posted by Wangda Tan <wh...@gmail.com>.
Sounds good to me.
On Fri, Sep 27, 2019 at 1:33 PM Wei-Chiu Chuang <we...@apache.org> wrote:
> Hi,
> I noticed that some non-trivial PRs are committed within hours. As an
> Example <https://github.com/apache/hadoop-submarine/pull/17>, this PR
> implements a new set of APIs, and was committed in just 3 hours.
>
> While I understand the desire to move the project quickly, please realize
> that Apache contributors are global, in all time zones, and we should
> strive to be more inclusive. By not allowing sufficient time for others to
> participate, we exclude people from a different time zone from contributing
> to this project. We won't be able to grow this community.
>
> A usual practice within the Hadoop community is to +1, and then delay the
> commit by 24 hours for a sizable change. I've also seen people delaying the
> commit by several days for a controversial change. Trivial changes such as
> typo or doc update doesn't need to respect this convention though.
>
> Thoughts?
>
> Best,
> Wei-Chiu
>
--
Sent from Gmail Mobile