You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "zhaixiaoxiang (GitHub)" <gi...@apache.org> on 2019/03/11 08:09:37 UTC

[GitHub] [incubator-dubbo] zhaixiaoxiang opened pull request #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

## What is the purpose of the change

Fix #619 , and PR #2956 is not enough in the following use case:

In souche.com, we add 'trace' function in dubbo, such as in FailoverClusterInvoker.doInvoke, we get stackTrace from exception to log detail exception info using the following:

`org.apache.commons.lang3.exception.ExceptionUtils.getStackTrace(result.getException())`

The above sentence will result the same problem with issue #619 .

So, we should solve this in decode stage.

#619 这个问题, PR #2956 貌似已经解决了, 但是我们公司(souche.com)在对dubbo加全链路埋点时, 还是遇到了之前的问题, 因为 #2956 是在InvokerInvocationHandler.invoke()方法的invoker.invoke(invocation)后解决了问题, 但是我们在FailoverClusterInvoker.doInvoke()方法里坐全链路埋点时, 为了能取到异常栈的信息, 用了如下的语句:
`org.apache.commons.lang3.exception.ExceptionUtils.getStackTrace(result.getException())`
导致了异常栈又出问题了..

所以应该在decode后, 对exception对象做判断才对.

## Brief changelog

RpcResult.java
RpcResultTest.java

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zhaixiaoxiang commented on pull request #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "zhaixiaoxiang (GitHub)" <gi...@apache.org>.
@carryxyh Any suggestions to my following docs?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on pull request #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Hi, xiang
I mean a java comment like this:

```
    /**
     * we need deal the stack trace to avoid NullPointerException
     * <p>
     * see https://github.com/apache/incubator-dubbo/pull/2956
     * and https://github.com/apache/incubator-dubbo/issues/619
     *
     * @param e exception
     * @return exception after deal with stack trace
     */
```

What do u think?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=h1) Report
> Merging [#3634](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/5f19335477a9ea4eb0af0dd0bdbe068b4e309edd?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `25.92%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3634      +/-   ##
============================================
- Coverage     63.95%   63.93%   -0.03%     
  Complexity       71       71              
============================================
  Files           700      700              
  Lines         30646    30711      +65     
  Branches       4946     4974      +28     
============================================
+ Hits          19601    19634      +33     
- Misses         8782     8819      +37     
+ Partials       2263     2258       -5
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/src/main/java/com/alibaba/dubbo/rpc/Invoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9JbnZva2VyLmphdmE=) | `0% <0%> (-36.37%)` | `0 <0> (ø)` | |
| [.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnRXcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `64.1% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `93.33% <100%> (+0.47%)` | `0 <0> (ø)` | :arrow_down: |
| [.../main/java/org/apache/dubbo/qos/server/Server.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3NlcnZlci9TZXJ2ZXIuamF2YQ==) | `72.09% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==) | `97.05% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../src/main/java/org/apache/dubbo/rpc/RpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNSZXN1bHQuamF2YQ==) | `94.11% <85.71%> (-2.76%)` | `0 <0> (ø)` | |
| [...le/src/main/java/com/alibaba/dubbo/rpc/Filter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9GaWx0ZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=footer). Last update [5f19335...719fb59](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zhaixiaoxiang commented on pull request #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "zhaixiaoxiang (GitHub)" <gi...@apache.org>.
this pr is just optimization for #2956 , and the docs for #2956 : https://www.yuque.com/fa902k/id5z6r/sr041v

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=h1) Report
> Merging [#3634](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/b2bfbc76d13106a3211f5af1713ba50848560060?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `85.71%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3634      +/-   ##
============================================
+ Coverage     63.44%   63.51%   +0.06%     
  Complexity       71       71              
============================================
  Files           703      706       +3     
  Lines         31000    32096    +1096     
  Branches       5024     5311     +287     
============================================
+ Hits          19669    20386     +717     
- Misses         9066     9370     +304     
- Partials       2265     2340      +75
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../src/main/java/org/apache/dubbo/rpc/RpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNSZXN1bHQuamF2YQ==) | `94.11% <85.71%> (-2.76%)` | `0 <0> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-13.05%)` | `0% <0%> (ø)` | |
| [...mmon/threadpool/support/AbortPolicyWithReport.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zdXBwb3J0L0Fib3J0UG9saWN5V2l0aFJlcG9ydC5qYXZh) | `83.33% <0%> (-5.56%)` | `0% <0%> (ø)` | |
| [...pport/zookeeper/ZookeeperDynamicConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9zdXBwb3J0L3pvb2tlZXBlci9ab29rZWVwZXJEeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `77.96% <0%> (-5.37%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-3.28%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `72.97% <0%> (-2.71%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/ArgumentConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Bcmd1bWVudENvbmZpZy5qYXZh) | `100% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnRXcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...ookeeper/ZookeeperDynamicConfigurationFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9zdXBwb3J0L3pvb2tlZXBlci9ab29rZWVwZXJEeW5hbWljQ29uZmlndXJhdGlvbkZhY3RvcnkuamF2YQ==) | `100% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=footer). Last update [b2bfbc7...13e1ce4](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on pull request #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Can you provide some more valuable docs?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh closed pull request #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
[ pull request closed by carryxyh ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zhaixiaoxiang commented on pull request #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "zhaixiaoxiang (GitHub)" <gi...@apache.org>.
ok

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zhaixiaoxiang commented on issue #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "zhaixiaoxiang (GitHub)" <gi...@apache.org>.
@ralf0131 Could you help trigger CI again? This PR failed previously because the junit test failed: #3657 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zhaixiaoxiang commented on issue #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "zhaixiaoxiang (GitHub)" <gi...@apache.org>.
@carryxyh 谢谢你的建议.

大家在看这个 PR 前建议先看下 PR #2956 , 那里分析了出现issue #619 的原因.

PR #2956 那样改在社区版里看上去是没有问题的, 但是在某些情况下会有问题:

比如我们公司在FailoverClusterInvoker.doInvoke()里加了全链路监控埋点的代码, 如下所示:

![image](https://user-images.githubusercontent.com/11908486/54118472-0daaea00-442e-11e9-9533-3517670d4814.png)

在finally块里, 我们会取详细的exception异常栈(如果有的话), 然后记录在链路日志中, 用的如下这段:
`info.setExceptionStr(ExceptionUtils.getStackTrace(result.getException()));`

在执行这段代码之前, result.getException()里的stackTrace是null, 这没有问题, 因为服务端本来就抛出了没有异常栈的NullPointerException, (如果这里不懂的话, 建议先看一下 #2956 , 那里有详细的分析).

但是执行完这段代码后, 见如下截图:
![image](https://user-images.githubusercontent.com/11908486/54118802-da1c8f80-442e-11e9-9d7c-6221d681b0e1.png)

stackTrace 就变成了错误的异常栈, 也就是 issue #619 中出现那个误导用户的异常栈, 之所以在PR #2956 后还是有这个问题, 是因为是先执行的上面那块代码, 然后再执行RpcResult.recreate(), 而PR #2956 是在recreate里做的修改, 其实应该是在DecodeableRpcResult 类的handleException()方法里做异常栈的判断和修改:
![image](https://user-images.githubusercontent.com/11908486/54119315-fd940a00-442f-11e9-9d55-a8786d91f279.png)

![image](https://user-images.githubusercontent.com/11908486/54119342-0d135300-4430-11e9-9fdc-220d784f88a3.png)

本 PR 的目的是优化 PR #2956 , 在decode时就实现异常栈的检测和修改, 而不是等到InvokerInvocationHandler.invoke()后, recreate()时再做检测, 否则如果用户做二次开发时, 在诸如FailoverClusterInvoker.doInvoke()里用类似ExceptionUtils.getStackTrace()方法就破坏了异常栈, 所以要在源头就做好检测和修改, 这样更好一点.


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on pull request #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Sorry, there is a problem with my expression, I mean a comment like this:

```
// Process string to char array for generic invoke
// See
// - https://github.com/apache/incubator-dubbo/issues/2003
```

Make it easier for developers to know the reason for this change.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=h1) Report
> Merging [#3634](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/5f19335477a9ea4eb0af0dd0bdbe068b4e309edd?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `85.71%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3634      +/-   ##
============================================
- Coverage     63.95%   63.95%   -0.01%     
  Complexity       71       71              
============================================
  Files           700      700              
  Lines         30646    30686      +40     
  Branches       4946     4973      +27     
============================================
+ Hits          19601    19625      +24     
- Misses         8782     8794      +12     
- Partials       2263     2267       +4
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../src/main/java/org/apache/dubbo/rpc/RpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNSZXN1bHQuamF2YQ==) | `94.11% <85.71%> (-2.76%)` | `0 <0> (ø)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `57.64% <0%> (-4.71%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0%> (-3.85%)` | `0% <0%> (ø)` | |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `69.64% <0%> (-3.58%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-3.28%)` | `0% <0%> (ø)` | |
| [...ting/exchange/support/header/HeartbeatHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRIYW5kbGVyLmphdmE=) | `84.44% <0%> (-1.92%)` | `0% <0%> (ø)` | |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `68.42% <0%> (-1.23%)` | `0% <0%> (ø)` | |
| [...e/dubbo/remoting/transport/netty4/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50LmphdmE=) | `74.6% <0%> (-1.21%)` | `0% <0%> (ø)` | |
| [...he/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNsaWVudC5qYXZh) | `66.1% <0%> (-1.14%)` | `0% <0%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3634/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=footer). Last update [5f19335...935a67a](https://codecov.io/gh/apache/incubator-dubbo/pull/3634?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zhaixiaoxiang commented on issue #3634: [Dubbo-619] Fix #619 and PR #2956 is not enough

Posted by "zhaixiaoxiang (GitHub)" <gi...@apache.org>.
@carryxyh hi, could you tell me why merging is blocked, thank you.

![image](https://user-images.githubusercontent.com/11908486/55380010-77ac4000-5551-11e9-9491-3fec05529acd.png)


![image](https://user-images.githubusercontent.com/11908486/55379953-46337480-5551-11e9-94cf-fc18d7395c2f.png)



[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3634 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org