You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Antoine Pitrou (JIRA)" <ji...@apache.org> on 2018/04/05 13:36:01 UTC

[jira] [Resolved] (ARROW-2380) [Python] Correct issues in numpy_to_arrow conversion routines

     [ https://issues.apache.org/jira/browse/ARROW-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antoine Pitrou resolved ARROW-2380.
-----------------------------------
    Resolution: Fixed

Issue resolved by pull request 1835
[https://github.com/apache/arrow/pull/1835]

> [Python] Correct issues in numpy_to_arrow conversion routines
> -------------------------------------------------------------
>
>                 Key: ARROW-2380
>                 URL: https://issues.apache.org/jira/browse/ARROW-2380
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>    Affects Versions: 0.9.0
>            Reporter: Bryan Cutler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.10.0
>
>
> Following the discussion at [https://github.com/apache/arrow/pull/1689,] there are a few issues with conversion of various types to arrow that are incorrect or could be improved:
>  * PyBytes_GET_SIZE is being casted to the wrong type, for example 
> {{const int32_t length = static_cast<int32_t>(PyBytes_GET_SIZE(obj));}}
>  * Handle the possibility with the statement
> {{builder->value_data_length() + length > kBinaryMemoryLimit}}
> if length is larger than kBinaryMemoryLimit
>  * Look into using common code for binary object conversion to avoid duplication, and allow support for bytes and bytearray objects in other places than numpy_to_arrow.  (possibly put in src/arrow/python/helpers.h)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)