You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/15 04:16:13 UTC
[GitHub] [camel] mrinalsharma opened a new pull request, #8717: Camel 18719 : camel-jbang - Adding the dependency of camel-quarkus-core creates two entries in exported POM.xml
mrinalsharma opened a new pull request, #8717:
URL: https://github.com/apache/camel/pull/8717
This pull request fixes [CAMEL-18719](https://issues.apache.org/jira/browse/CAMEL-18719)
- `dep = dep.substring(0, dep.lastIndexOf(","));` removed extra `,` that was causing an empty dependency in pom.xml
- quarkus-pom.tmpl already have camel-quarkus-core, camel-quarkus-platform-http, camel-quarkus-microprofile-health included so there was no need to add it again if dependency was passed as `--deps`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8717: Camel 18719 : camel-jbang - Adding the dependency of camel-quarkus-core creates two entries in exported POM.xml
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8717:
URL: https://github.com/apache/camel/pull/8717#issuecomment-1316476674
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mrinalsharma closed pull request #8717: Camel 18719 : camel-jbang - Adding the dependency of camel-quarkus-core creates two entries in exported POM.xml
Posted by GitBox <gi...@apache.org>.
mrinalsharma closed pull request #8717: Camel 18719 : camel-jbang - Adding the dependency of camel-quarkus-core creates two entries in exported POM.xml
URL: https://github.com/apache/camel/pull/8717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8717: Camel 18719 : camel-jbang - Adding the dependency of camel-quarkus-core creates two entries in exported POM.xml
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8717:
URL: https://github.com/apache/camel/pull/8717#issuecomment-1320918655
@mrinalsharma do you have time to fix that last comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mrinalsharma commented on pull request #8717: Camel 18719 : camel-jbang - Adding the dependency of camel-quarkus-core creates two entries in exported POM.xml
Posted by GitBox <gi...@apache.org>.
mrinalsharma commented on PR #8717:
URL: https://github.com/apache/camel/pull/8717#issuecomment-1320931153
>
Sorry, got stuck in a personal issue. Will try to finish it today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #8717: Camel 18719 : camel-jbang - Adding the dependency of camel-quarkus-core creates two entries in exported POM.xml
Posted by GitBox <gi...@apache.org>.
davsclaus commented on code in PR #8717:
URL: https://github.com/apache/camel/pull/8717#discussion_r1024565087
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java:
##########
@@ -342,6 +342,7 @@ private int run() throws Exception {
if (dep == null) {
dep = dependencies;
} else if (dependencies != null && !dependencies.equals(dep)) {
+ dep = dep.substring(0, dep.lastIndexOf(","));
Review Comment:
What if there is no comma in dep, then indexOf returns -1 and substring will fail. I think we need to check if dep ends with comma we can avoid adding the comma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8717: Camel 18719 : camel-jbang - Adding the dependency of camel-quarkus-core creates two entries in exported POM.xml
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8717:
URL: https://github.com/apache/camel/pull/8717#issuecomment-1321834054
Ah yeah this PR seems wrong now, you can try to create a new clean PR with only your changes, and then close this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mrinalsharma commented on pull request #8717: Camel 18719 : camel-jbang - Adding the dependency of camel-quarkus-core creates two entries in exported POM.xml
Posted by GitBox <gi...@apache.org>.
mrinalsharma commented on PR #8717:
URL: https://github.com/apache/camel/pull/8717#issuecomment-1322244812
created a new Pull request https://github.com/apache/camel/pull/8749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8717: Camel 18719 : camel-jbang - Adding the dependency of camel-quarkus-core creates two entries in exported POM.xml
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8717:
URL: https://github.com/apache/camel/pull/8717#issuecomment-1320968252
@mrinalsharma no rush, we need this within 2 weeks before we cut the 3.20 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org