You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Raul Gutierrez Segales (JIRA)" <ji...@apache.org> on 2015/04/29 03:33:06 UTC
[jira] [Commented] (ZOOKEEPER-2176) unclear error message should be
info or warn
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518526#comment-14518526 ]
Raul Gutierrez Segales commented on ZOOKEEPER-2176:
---------------------------------------------------
cc: [~michim], [~hdeng]
> unclear error message should be info or warn
> --------------------------------------------
>
> Key: ZOOKEEPER-2176
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2176
> Project: ZooKeeper
> Issue Type: Improvement
> Components: quorum
> Affects Versions: 3.5.0, 3.5.1, 3.5.2
> Reporter: Raul Gutierrez Segales
> Assignee: Raul Gutierrez Segales
> Attachments: ZOOKEEPER-2176.patch
>
>
> Hi [~shralex],
> Looking at the CI output of ZOOKEEPER-2163 I see this:
> {noformat}
> [exec] [junit] 2015-04-17 17:36:23,750 [myid:] - ERROR [QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:11235)(secure=disabled):QuorumPeer@1394] - writeToDisk == true but configFilename == null
> {noformat}
> Though looking at QuorumPeer#setQuorumVerifier I see:
> {noformat}
> if (configFilename != null) {
> try {
> String dynamicConfigFilename = makeDynamicConfigFilename(
> qv.getVersion());
> QuorumPeerConfig.writeDynamicConfig(
> dynamicConfigFilename, qv, false);
> QuorumPeerConfig.editStaticConfig(configFilename,
> dynamicConfigFilename,
> needEraseClientInfoFromStaticConfig());
> } catch (IOException e) {
> LOG.error("Error closing file: ", e.getMessage());
> }
> } else {
> LOG.error("writeToDisk == true but configFilename == null");
> }
> {noformat}
> there's no proper error handling so I guess maybe we should just make it a warning? Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)