You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/08/10 03:57:37 UTC
[GitHub] [orc] williamhyun opened a new pull request, #1217: ORC-1246: Revamp ORC website
williamhyun opened a new pull request, #1217:
URL: https://github.com/apache/orc/pull/1217
### What changes were proposed in this pull request?
This PR aims to revamp the ORC website.
### Why are the changes needed?
To improve the followings:
- Increase page width and improve resizing
- Create `RELEASES` menu
- Menu reordering
- Improve mobile device UX
- Fix the broken layout in the footer
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1217: ORC-1246: Revamp ORC website
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1217:
URL: https://github.com/apache/orc/pull/1217#issuecomment-1211155302
To @guiyanakuang , when I tried your patch. The ratio is good but it's overflew still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #1217: ORC-1246: Revamp ORC website
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on PR #1217:
URL: https://github.com/apache/orc/pull/1217#issuecomment-1210271914
How about getting the asf logo size to autoscale to the resolution at a small resolution. I replaced L354-358 with the code below and it looks good.
```css
img {
margin: -30px 0 0;
object-fit: contain;
max-width: 100%;
max-height: 100%;
width: auto;
height: auto;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1217: ORC-1246: Revamp ORC website
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1217:
URL: https://github.com/apache/orc/pull/1217#issuecomment-1211159097
Since the Apache Logo distortion is one of the old website issue, let's handle them separately. Let me merge this first to help William move forward further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1217: ORC-1246: Revamp ORC website
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #1217: ORC-1246: Revamp ORC website
URL: https://github.com/apache/orc/pull/1217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #1217: ORC-1246: Revamp ORC website
Posted by GitBox <gi...@apache.org>.
williamhyun commented on PR #1217:
URL: https://github.com/apache/orc/pull/1217#issuecomment-1210134046
cc: @dongjoon-hyun , @wgtmac , @pgaref , @guiyanakuang , @stiga-huang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1217: ORC-1246: Revamp ORC website
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1217:
URL: https://github.com/apache/orc/pull/1217#issuecomment-1210951214
+1 for @guiyanakuang 's comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1217: ORC-1246: Revamp ORC website
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1217:
URL: https://github.com/apache/orc/pull/1217#issuecomment-1211545766
Oh, it seems that Jekyll is working differently from Apache ORC website serving.
After I published, I realized that the `Release` link is not working while Jekyll serves it well.
Let me take a look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #1217: ORC-1246: Revamp ORC website
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on PR #1217:
URL: https://github.com/apache/orc/pull/1217#issuecomment-1210267443
Thank you, @williamhyun.
I tested at small resolutions and the aspect ratio of the asf logo looks incorrect.
https://github.com/apache/orc/blob/edccbd80865d06cc6d6207a41661a1db5313f4e6/site/css/screen.scss#L354-L358
The original size of the image is 475 * 175 px.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1217: ORC-1246: Revamp ORC website
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1217:
URL: https://github.com/apache/orc/pull/1217#discussion_r942816448
##########
site/README.md:
##########
@@ -11,12 +11,12 @@ the site is to use docker to use a standard environment.
## Run the docker container with the preview of the site.
-1. `docker run -d --name orc-container -p 4000:4000 apache/orc-dev:site`
+1. `docker run -d --name orc-container -p 4000:4000 -v $PWD:/home/orc/site apache/orc-dev:site`
## Browsing
Look at the site by navigating to
-[http://0.0.0.0:4000/](http://0.0.0.0:4000/) .
+[http://localhost:4000/](http://localhost:4000/) .
Review Comment:
BTW, let's revert this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1217: ORC-1246: Revamp ORC website
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1217:
URL: https://github.com/apache/orc/pull/1217#issuecomment-1211160549
Merged to main/1.8. Thank you, @williamhyun and @guiyanakuang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org