You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/26 09:37:04 UTC

[GitHub] [incubator-nuttx] codebje opened a new pull request #3609: Add experimental support for an eZ80 toolchain using llvm and GNU binutils

codebje opened a new pull request #3609:
URL: https://github.com/apache/incubator-nuttx/pull/3609


   ## Summary
   
   Add experimental support for an eZ80 toolchain using llvm and GNU binutils.
   
   An additional fix for the RTC driver to lock the RTC after setting values instead of unlocking it is included.
   
   ## Impact
   
   Allows a non-supported fork of llvm with Z80 support to be used to build ELF objects, and GNU binutils compiled with Z80 support enabled to be used as a linker. There are modifications to support 64-bit integers, and further modifications to allow a toolchain to support LONG LONG without supporting DOUBLE.
   
   The assembly code for the eZ80 has been modified to support compilation using both ZDS-II and GNU assembler. This is partially accomplished with macros for the GNU assembler to partially implement the ZDS-II assembler directives.
   
   ## Testing
   
   I am using this toolchain to regularly build for the eZ80, with an additional (forthcoming) patch to add ELF support for the architecture. I have compiled the modified assembly using ZDS-II on a Linux VM using Wine, but not executed the result. I have validated boot code, interrupt handling, and drivers for SPI, Ethernet, and UART.
   
   There is an error somewhere in the Ethernet driver that will occasionally lock the driver up if the receive buffer overflows. The error is not introduced by this patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] codebje commented on pull request #3609: Add experimental support for an eZ80 toolchain using llvm and GNU binutils

Posted by GitBox <gi...@apache.org>.
codebje commented on pull request #3609:
URL: https://github.com/apache/incubator-nuttx/pull/3609#issuecomment-828845364


   > @codebje could you enable z80 CI? it will avoid breaking z80 arch in the future. Only a few file need to change:
   
   I would like to do this, though there's a few roadblocks to sort out - the intrinsics mostly come from Zilog and aren't licensed for redistribution, and there's no prebuilt llvm for Z80+binutils yet. For CI builds I can make a prebuilt toolchain with stub intrinsics. The resulting binary won't run properly but the build will be tested without license issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3609: Add experimental support for an eZ80 toolchain using llvm and GNU binutils

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3609:
URL: https://github.com/apache/incubator-nuttx/pull/3609#discussion_r620587703



##########
File path: arch/z80/include/ez80/inttypes.h
##########
@@ -116,6 +116,7 @@
 #  define INT16_C(x)  x
 #  define INT24_C(x)  x
 #  define INT32_C(x)  x ## l
+#  define INT32_C(x)  x ## l

Review comment:
       Duplicated definition of the `INT32_C` macro




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3609: Add experimental support for an eZ80 toolchain using llvm and GNU binutils

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3609:
URL: https://github.com/apache/incubator-nuttx/pull/3609#issuecomment-828521726


   @codebje could you enable z80 CI? it will avoid breaking z80 arch in the future. Only a few file need to change:
   https://github.com/apache/incubator-nuttx/blob/master/tools/ci/docker/linux/Dockerfile
   https://github.com/apache/incubator-nuttx/blob/master/tools/ci/testlist/other.dat


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis merged pull request #3609: Add experimental support for an eZ80 toolchain using llvm and GNU binutils

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #3609:
URL: https://github.com/apache/incubator-nuttx/pull/3609


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org