You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/02/17 15:09:33 UTC

[GitHub] flink pull request: Improve TaskManagerTest#testRemotePartitionNot...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/1658

    Improve TaskManagerTest#testRemotePartitionNotFound failure message

    I've observed a failure in TaskManagerTest#testRemotePartitionNotFound, but the exception was essentially swallowed. I've added an error message containing the swallowed exceptions message, in case it occurs again.
    
    Below is the stacktrace i got:
    
    testRemotePartitionNotFound(org.apache.flink.runtime.taskmanager.TaskManagerTest)  Time elapsed: 16.178 sec  <<< FAILURE!
    java.lang.AssertionError: expected:<class org.apache.flink.runtime.io.network.partition.PartitionNotFoundException> but was:<class java.lang.Exception>
            at org.junit.Assert.fail(Assert.java:88)
            at org.junit.Assert.failNotEquals(Assert.java:743)
            at org.junit.Assert.assertEquals(Assert.java:118)
            at org.junit.Assert.assertEquals(Assert.java:144)
            at org.apache.flink.runtime.taskmanager.TaskManagerTest$7$1.run(TaskManagerTest.java:922)
            at akka.testkit.JavaTestKit$Within$1.apply(JavaTestKit.java:232)
            at akka.testkit.TestKitBase$class.within(TestKit.scala:296)
            at akka.testkit.TestKit.within(TestKit.scala:718)
            at akka.testkit.TestKitBase$class.within(TestKit.scala:310)
            at akka.testkit.TestKit.within(TestKit.scala:718)
            at akka.testkit.JavaTestKit$Within.<init>(JavaTestKit.java:230)
            at org.apache.flink.runtime.taskmanager.TaskManagerTest$7$1.<init>(TaskManagerTest.java:910)
            at org.apache.flink.runtime.taskmanager.TaskManagerTest$7.<init>(TaskManagerTest.java:910)
            at org.apache.flink.runtime.taskmanager.TaskManagerTest.testRemotePartitionNotFound(TaskManagerTest.java:850)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink misc_tmt

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1658.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1658
    
----
commit d6d83966a81073c3d487a3ad521364adefe9e360
Author: zentol <s....@web.de>
Date:   2016-02-17T14:06:15Z

    Improve TaskManagerTest#testRemotePartitionNotFound failure message

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Improve TaskManagerTest#testRemotePartitionNot...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1658


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Improve TaskManagerTest#testRemotePartitionNot...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:

    https://github.com/apache/flink/pull/1658#issuecomment-193817912
  
    merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---