(kafka) branch trunk updated: MINOR: Fix flaky `MetadataLoaderTest.testNoPublishEmptyImage` (#14875)

[jg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jgus pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new a35e021925d MINOR: Fix flaky `MetadataLoaderTest.testNoPublishEmptyImage` (#14875)
a35e021925d is described below

commit a35e021925d2ac371497a823a5ae81271193a3fd
Author: Jason Gustafson <ja...@confluent.io>
AuthorDate: Thu Nov 30 09:50:19 2023 -0800

    MINOR: Fix flaky `MetadataLoaderTest.testNoPublishEmptyImage` (#14875)
    
    There is a race in the assertion on `capturedImages`. Since the future is signaled first, it is still possible to see an empty list. By adding to the collection first, we can ensure the assertion will succeed.
    
    Reviewers: Reviewers: David Jacot <dj...@confluent.io>
---
 .../src/test/java/org/apache/kafka/image/loader/MetadataLoaderTest.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/metadata/src/test/java/org/apache/kafka/image/loader/MetadataLoaderTest.java b/metadata/src/test/java/org/apache/kafka/image/loader/MetadataLoaderTest.java
index 62d974b8b5c..921c241a09a 100644
--- a/metadata/src/test/java/org/apache/kafka/image/loader/MetadataLoaderTest.java
+++ b/metadata/src/test/java/org/apache/kafka/image/loader/MetadataLoaderTest.java
@@ -793,10 +793,10 @@ public class MetadataLoaderTest {
 
             @Override
             public void onMetadataUpdate(MetadataDelta delta, MetadataImage newImage, LoaderManifest manifest) {
+                capturedImages.add(newImage);
                 if (!firstPublish.isDone()) {
                     firstPublish.complete(null);
                 }
-                capturedImages.add(newImage);
             }
         };