[whimsy] branch master updated: AFAICT Committee.member[id]s methods are no longer used

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new e7e8d14  AFAICT Committee.member[id]s methods are no longer used
e7e8d14 is described below

commit e7e8d14a6eb78cdff5af3dd38ea650fd3a0808d4
Author: Sebb <se...@apache.org>
AuthorDate: Mon Feb 18 18:03:22 2019 +0000

    AFAICT Committee.member[id]s methods are no longer used
---
 lib/whimsy/asf/ldap.rb | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index a877529..59b119b 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -1239,7 +1239,6 @@ module ASF
 
   class Committee < Base
     # TODO what to do about this? Change to ou=project or drop?
-    # It's used by the methods: member[id]s
     @base = 'ou=pmc,ou=committees,ou=groups,dc=apache,dc=org'
 
     # Date this committee was last modified in LDAP.
@@ -1255,26 +1254,6 @@ module ASF
       (ASF::Committee.pmcs+ASF::Committee.nonpmcs).map(&:name).include?(name) ? committee : nil
     end
 
-    # DO NOT USE: relies on outdated ou=pmc LDAP. Uses owners instead.
-    def members
-      Wunderbar.warn("Committee.members #{caller[0,4]}")
-      members = weakref(:members) do
-        ASF.search_one(base, "cn=#{name}", 'member').flatten
-      end
-
-      members.map {|uid| Person.find uid[/uid=(.*?),/,1]}
-    end
-
-    # DO NOT USE: relies on outdated ou=pmc LDAP. Uses ownerids instead.
-    def memberids
-      Wunderbar.warn("Committee.memberids #{caller[0,4]}")
-      members = weakref(:members) do
-        ASF.search_one(base, "cn=#{name}", 'member').flatten
-      end
-    
-      members.map {|uid| uid[/uid=(.*?),/,1]}
-    end
-
     # List of owners for this committee, i.e. people who are members of the
     # committee and have update access.  Data is obtained from LDAP.
     # Takes info from Project