You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "jrudolph (via GitHub)" <gi...@apache.org> on 2023/02/08 14:35:34 UTC
[GitHub] [incubator-pekko-sbt-paradox] jrudolph opened a new pull request, #9: setup plugin based on sbt-paradox-material-theme
jrudolph opened a new pull request, #9:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/9
Here's some initial setup that (re)uses sbt-paradox-material-theme.
Let's see how inheriting a theme like this will work in the future but at least it provides an initial setup that already offers quite a lot (like working client-side full text search).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] jrudolph commented on pull request #9: setup plugin based on sbt-paradox-material-theme
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #9:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/9#issuecomment-1422702463
Would like this on pekko core:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] jrudolph merged pull request #9: setup plugin based on sbt-paradox-material-theme
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph merged PR #9:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] mdedetrich commented on a diff in pull request #9: setup plugin based on sbt-paradox-material-theme
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #9:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/9#discussion_r1101197788
##########
build.sbt:
##########
@@ -57,9 +58,10 @@ lazy val pekkoPlugin = project
addSbtPlugin(
// When updating the sbt-paradox version,
// remember to also update project/plugins.sbt
- "com.lightbend.paradox" % "sbt-paradox" % "0.10.3"),
- addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-apidoc" % "1.0.0"),
- addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-project-info" % "3.0.0"),
+ "com.lightbend.paradox" % "sbt-paradox" % "0.9.2"),
Review Comment:
Is there a reason you downgraded the dependencies? I suspect this may be due to pekko-core however there is a workaround for this (see https://github.com/apache/incubator-pekko/issues/92#issue-1523977563)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] jrudolph commented on a diff in pull request #9: setup plugin based on sbt-paradox-material-theme
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #9:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/9#discussion_r1101245949
##########
build.sbt:
##########
@@ -57,9 +58,10 @@ lazy val pekkoPlugin = project
addSbtPlugin(
// When updating the sbt-paradox version,
// remember to also update project/plugins.sbt
- "com.lightbend.paradox" % "sbt-paradox" % "0.10.3"),
- addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-apidoc" % "1.0.0"),
- addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-project-info" % "3.0.0"),
+ "com.lightbend.paradox" % "sbt-paradox" % "0.9.2"),
Review Comment:
> that we do have the problem with projects outside of pekko-core not needing JDK 1.8 (
That's true but also not a problem since 1.8 artifacts would work anywhere...
> pekko-core is the outlier here I think it makes sense to use the latest dependencies for the plugin.
I changed it now to the latest but like this there will always be the risk of changing something here and it will not work in pekko core because of incompatibilities...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] jrudolph commented on a diff in pull request #9: setup plugin based on sbt-paradox-material-theme
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #9:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/9#discussion_r1101200641
##########
build.sbt:
##########
@@ -57,9 +58,10 @@ lazy val pekkoPlugin = project
addSbtPlugin(
// When updating the sbt-paradox version,
// remember to also update project/plugins.sbt
- "com.lightbend.paradox" % "sbt-paradox" % "0.10.3"),
- addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-apidoc" % "1.0.0"),
- addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-project-info" % "3.0.0"),
+ "com.lightbend.paradox" % "sbt-paradox" % "0.9.2"),
Review Comment:
I can try if it works but it's of course not ideal since there is no compatibility guarantee that would ensure that a plugin compiled against the latest version would work against older versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] mdedetrich commented on a diff in pull request #9: setup plugin based on sbt-paradox-material-theme
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #9:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/9#discussion_r1101202910
##########
build.sbt:
##########
@@ -57,9 +58,10 @@ lazy val pekkoPlugin = project
addSbtPlugin(
// When updating the sbt-paradox version,
// remember to also update project/plugins.sbt
- "com.lightbend.paradox" % "sbt-paradox" % "0.10.3"),
- addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-apidoc" % "1.0.0"),
- addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-project-info" % "3.0.0"),
+ "com.lightbend.paradox" % "sbt-paradox" % "0.9.2"),
Review Comment:
So I did try this locally with the incubator-pekko-sbt-paradox and it worked (but that is without the theme). The reason why I am mentioning this is that we do have the problem with projects outside of pekko-core not needing JDK 1.8 and since pekko-core is the outlier here I think it makes sense to use the latest dependencies for the plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] mdedetrich commented on a diff in pull request #9: setup plugin based on sbt-paradox-material-theme
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #9:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/9#discussion_r1101202910
##########
build.sbt:
##########
@@ -57,9 +58,10 @@ lazy val pekkoPlugin = project
addSbtPlugin(
// When updating the sbt-paradox version,
// remember to also update project/plugins.sbt
- "com.lightbend.paradox" % "sbt-paradox" % "0.10.3"),
- addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-apidoc" % "1.0.0"),
- addSbtPlugin("com.lightbend.paradox" % "sbt-paradox-project-info" % "3.0.0"),
+ "com.lightbend.paradox" % "sbt-paradox" % "0.9.2"),
Review Comment:
So I did try this locally with the incubator-pekko-sbt-paradox and it worked (but that is without the theme). The reason why I am mentioning this is that we do have the problem with projects outside of pekko-core not needing JDK 1.8 (and later versions of JDK 1.8 do not work with these old versions iirc) and since pekko-core is the outlier here I think it makes sense to use the latest dependencies for the plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org