[GitHub] [incubator-druid] himanshug commented on issue #8242: should we deprecate fieldExpression and extractionFn field in various Aggregators, DimensionSpecs, Filters etc

[GitBox <gi...@apache.org>]

himanshug commented on issue #8242: should we deprecate fieldExpression and extractionFn field in various Aggregators, DimensionSpecs, Filters etc
URL: https://github.com/apache/incubator-druid/issues/8242#issuecomment-527640787
 
 
   I did a bit more digging and found that many filter implementations exploit the fact that whether they are working on values with extraction fn applied and make few optimizations . so, I think it is ok for filters to have extraction fn as fields.
   however, `DimensionSpec` also has knowledge of extractionFn and `getExtractionFn()` method, which looks like replaceable by usage of the future `ExtractionFnVirtualColumn`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org