You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/29 15:58:53 UTC
[GitHub] [arrow] zeroshade opened a new pull request #9836: ARROW-12138: [Go][IPC] Update flatbuffers definitions
zeroshade opened a new pull request #9836:
URL: https://github.com/apache/arrow/pull/9836
Updating the generated flatbuffer code so that newer features like compression in IPC can get implemented. Doing the updating of the flatbuffer generated code first as a separate change.
@sbinet @emkornfield
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #9836: ARROW-12138: [Go][IPC] Update flatbuffers definitions
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #9836:
URL: https://github.com/apache/arrow/pull/9836#issuecomment-810373785
@sbinet @emkornfield @wesm once this is merged, i have a PR ready for adding compression handling to the go IPC implementation, I'm just waiting for this to get merged before filing it for ease of review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #9836: ARROW-12138: [Go][IPC] Update flatbuffers definitions
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #9836:
URL: https://github.com/apache/arrow/pull/9836#issuecomment-809502755
All that was done for this change was to run `go run ./gen-flatbuffers.go` followed by updating the couple of files in the ipc module which had to switch direct references to `byte` or `int16` to the exported types from the flatbuffers files. So the only files in this change that contain anything that wasn't generated by flatc are ipc/file_writer.go, ipc/message.go and ipc/metadata.go. Everything else just contains the generated flatbuffer code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield closed pull request #9836: ARROW-12138: [Go][IPC] Update flatbuffers definitions
Posted by GitBox <gi...@apache.org>.
emkornfield closed pull request #9836:
URL: https://github.com/apache/arrow/pull/9836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9836: ARROW-12138: [Go][IPC] Update flatbuffers definitions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9836:
URL: https://github.com/apache/arrow/pull/9836#issuecomment-809789886
https://issues.apache.org/jira/browse/ARROW-12138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org