[GitHub] merlimat commented on a change in pull request #2824: Allow the ability to specify which artifactory to download dep from

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #2824: Allow the ability to specify which artifactory to download dep from
URL: https://github.com/apache/pulsar/pull/2824#discussion_r227485071
 
 

 ##########
 File path: pulsar-common/src/main/java/org/apache/pulsar/common/functions/FunctionConfig.java
 ##########
 @@ -91,4 +91,8 @@
     private Long timeoutMs;
     private String jar;
     private String py;
+
+    // Any non-default artifactory that need to be used to download dependencies
+    // This is going to be Runtime specific.
+    private String artifactory;
 
 Review comment:
   `artifactory` is the name of one specific product to manage the repository. 
   
   In practice, this can be whatever repository. Also should we clarify that this only applies to Python and Java still needs to be packaged with fat-jars?
   
   Renaming into `pythonDepenedenciesRepository` or similar name?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services