You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Bob Harner <bo...@gmail.com> on 2011/10/14 01:56:07 UTC
ComponentsParametersConstants.java - rename?
Maybe rename ComponentsParametersConstants.java to
ComponentParameterConstants.java ?
---------- Forwarded message ----------
From: <ml...@apache.org>
Date: Thu, Oct 13, 2011 at 9:20 AM
Subject: svn commit: r1182838 - in
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5:
ComponentsParametersConstants.java
corelib/components/FormInjector.java services/TapestryModule.java
To: commits@tapestry.apache.org
Author: mlusetti
Date: Thu Oct 13 13:20:48 2011
New Revision: 1182838
URL: http://svn.apache.org/viewvc?rev=1182838&view=rev
Log:
TAP5-16777 Fix a typo in injector name
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java?rev=1182838&r1=1182837&r2=1182838&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java
(original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java
Thu Oct 13 13:20:48 2011
@@ -74,6 +74,8 @@ public class ComponentsParametersConstan
* The default position where to insert content into {@link
org.apache.tapestry5.corelib.components.Form}.
* Default to "above".
*/
- public static final String FORMINJECOTR_INSERT_POSITION=
"tapestry.components.forminjector_insert_position";
+ public static final String FORMINJECTOR_INSERT_POSITION =
"tapestry.components.forminjector_insert_position";
+
+
}
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java?rev=1182838&r1=1182837&r2=1182838&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java
(original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java
Thu Oct 13 13:20:48 2011
@@ -20,29 +20,18 @@ import org.apache.tapestry5.*;
import org.apache.tapestry5.annotations.Environmental;
import org.apache.tapestry5.annotations.Events;
import org.apache.tapestry5.annotations.Parameter;
-import org.apache.tapestry5.annotations.RequestParameter;
import org.apache.tapestry5.annotations.SupportsInformalParameters;
import org.apache.tapestry5.corelib.data.InsertPosition;
-import org.apache.tapestry5.corelib.internal.ComponentActionSink;
-import org.apache.tapestry5.corelib.internal.HiddenFieldPositioner;
-import org.apache.tapestry5.corelib.internal.InternalFormSupport;
import org.apache.tapestry5.dom.Element;
import org.apache.tapestry5.internal.services.PageRenderQueue;
import org.apache.tapestry5.internal.services.RequestConstants;
import org.apache.tapestry5.ioc.annotations.Inject;
-import org.apache.tapestry5.ioc.util.IdAllocator;
import org.apache.tapestry5.json.JSONObject;
import org.apache.tapestry5.services.ClientBehaviorSupport;
-import org.apache.tapestry5.services.ClientDataEncoder;
-import org.apache.tapestry5.services.ComponentSource;
-import org.apache.tapestry5.services.Environment;
import org.apache.tapestry5.services.FormSupport;
-import org.apache.tapestry5.services.Heartbeat;
-import org.apache.tapestry5.services.HiddenFieldLocationRules;
import org.apache.tapestry5.services.PartialMarkupRenderer;
import org.apache.tapestry5.services.PartialMarkupRendererFilter;
import org.apache.tapestry5.services.javascript.JavaScriptSupport;
-import org.slf4j.Logger;
/**
* A way to add new content to an existing Form. The FormInjector
emulates its tag from the template (or uses a
@@ -70,7 +59,7 @@ public class FormInjector implements Cli
private Object[] context;
@Parameter(defaultPrefix = BindingConstants.LITERAL,
- value = BindingConstants.SYMBOL + ":" +
ComponentsParametersConstants.FORMINJECOTR_INSERT_POSITION)
+ value = BindingConstants.SYMBOL + ":" +
ComponentsParametersConstants.FORMINJECTOR_INSERT_POSITION)
private InsertPosition position;
/**
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java?rev=1182838&r1=1182837&r2=1182838&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java
(original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java
Thu Oct 13 13:20:48 2011
@@ -2368,7 +2368,7 @@ public final class TapestryModule
configuration.add(ComponentsParametersConstants.GRIDCOLUMNS_DESCENDING_ASSET,
GridConstants.COLUMNS_DESCENDING);
// FormInjector components parameters defaults
- configuration.add(ComponentsParametersConstants.FORMINJECOTR_INSERT_POSITION,
"above");
+ configuration.add(ComponentsParametersConstants.FORMINJECTOR_INSERT_POSITION,
"above");
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: ComponentsParametersConstants.java - rename?
Posted by Massimo Lusetti <ml...@gmail.com>.
On Fri, Oct 14, 2011 at 1:56 AM, Bob Harner <bo...@gmail.com> wrote:
> Maybe rename ComponentsParametersConstants.java to
> ComponentParameterConstants.java ?
Sure, you know way better then me.
Cheers
--
Massimo
http://meridio.blogspot.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org