You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Brock Noland (Created) (JIRA)" <ji...@apache.org> on 2012/02/11 20:04:59 UTC

[jira] [Created] (FLUME-963) TestHDFSEventSink.testBadSimpleAppend when output verified

TestHDFSEventSink.testBadSimpleAppend when output verified
----------------------------------------------------------

                 Key: FLUME-963
                 URL: https://issues.apache.org/jira/browse/FLUME-963
             Project: Flume
          Issue Type: Bug
          Components: Channel
    Affects Versions: v1.0.0
            Reporter: Brock Noland
             Fix For: v1.1.0


TestHDFSEventSink.testBadSimpleAppend only writes 57 events to the output as opposed to all 75. This can be verified by setting the environment variable hdfs_keepFiles or commenting out the tearDown method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-963) Add additional tes to TestHDFSEventSink and demystify existing tests

Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brock Noland updated FLUME-963:
-------------------------------

    Attachment: FLUME-963-0.patch

Patch attached.
                
> Add additional tes to TestHDFSEventSink and demystify existing tests
> --------------------------------------------------------------------
>
>                 Key: FLUME-963
>                 URL: https://issues.apache.org/jira/browse/FLUME-963
>             Project: Flume
>          Issue Type: Bug
>          Components: Channel
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>             Fix For: v1.1.0
>
>         Attachments: FLUME-963-0.patch, FLUME-963-test-verify.patch
>
>
> TestHDFSEventSink.testBadSimpleAppend only writes 57 events to the output as opposed to all 75. This can be verified by setting the environment variable hdfs_keepFiles or commenting out the tearDown method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-963) Add additional tes to TestHDFSEventSink and demystify existing tests

Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brock Noland updated FLUME-963:
-------------------------------

    Summary: Add additional tes to TestHDFSEventSink and demystify existing tests  (was: Add additional verifications to )
    
> Add additional tes to TestHDFSEventSink and demystify existing tests
> --------------------------------------------------------------------
>
>                 Key: FLUME-963
>                 URL: https://issues.apache.org/jira/browse/FLUME-963
>             Project: Flume
>          Issue Type: Bug
>          Components: Channel
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>             Fix For: v1.1.0
>
>         Attachments: FLUME-963-test-verify.patch
>
>
> TestHDFSEventSink.testBadSimpleAppend only writes 57 events to the output as opposed to all 75. This can be verified by setting the environment variable hdfs_keepFiles or commenting out the tearDown method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-963) Add additional tes to TestHDFSEventSink and demystify existing tests

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206750#comment-13206750 ] 

jiraposter@reviews.apache.org commented on FLUME-963:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3869/#review5047
-----------------------------------------------------------

Ship it!


- Prasad


On 2012-02-11 20:35:37, Brock Noland wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3869/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-11 20:35:37)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Adds verification to testAppend and testBadSimpleAppend.
bq.  Creates common verification method and changes all tests which output data to this method.
bq.  Changes testBadSimpleAppend to all events are processed by sink. 
bq.  
bq.  
bq.  This addresses bug FLUME-963.
bq.      https://issues.apache.org/jira/browse/FLUME-963
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java 798028f 
bq.  
bq.  Diff: https://reviews.apache.org/r/3869/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran unit tests in this class in eclipse and all tests through maven.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Brock
bq.  
bq.


                
> Add additional tes to TestHDFSEventSink and demystify existing tests
> --------------------------------------------------------------------
>
>                 Key: FLUME-963
>                 URL: https://issues.apache.org/jira/browse/FLUME-963
>             Project: Flume
>          Issue Type: Bug
>          Components: Channel
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>             Fix For: v1.1.0
>
>         Attachments: FLUME-963-0.patch, FLUME-963-test-verify.patch
>
>
> TestHDFSEventSink.testBadSimpleAppend only writes 57 events to the output as opposed to all 75. This can be verified by setting the environment variable hdfs_keepFiles or commenting out the tearDown method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-963) TestHDFSEventSink.testBadSimpleAppend when output verified

Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brock Noland updated FLUME-963:
-------------------------------

    Attachment: FLUME-963-test-verify.patch

The attached patch verifies the output contents of the test.
                
> TestHDFSEventSink.testBadSimpleAppend when output verified
> ----------------------------------------------------------
>
>                 Key: FLUME-963
>                 URL: https://issues.apache.org/jira/browse/FLUME-963
>             Project: Flume
>          Issue Type: Bug
>          Components: Channel
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>             Fix For: v1.1.0
>
>         Attachments: FLUME-963-test-verify.patch
>
>
> TestHDFSEventSink.testBadSimpleAppend only writes 57 events to the output as opposed to all 75. This can be verified by setting the environment variable hdfs_keepFiles or commenting out the tearDown method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (FLUME-963) Add additional tests to TestHDFSEventSink and demystify existing tests

Posted by "Prasad Mujumdar (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prasad Mujumdar resolved FLUME-963.
-----------------------------------

    Resolution: Fixed

Patch committed to 1.x (flume-728) branch.

Thanks Brock !
                
> Add additional tests to TestHDFSEventSink and demystify existing tests
> ----------------------------------------------------------------------
>
>                 Key: FLUME-963
>                 URL: https://issues.apache.org/jira/browse/FLUME-963
>             Project: Flume
>          Issue Type: Bug
>          Components: Channel
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>             Fix For: v1.1.0
>
>         Attachments: FLUME-963-0.patch, FLUME-963-1.patch, FLUME-963-test-verify.patch
>
>
> TestHDFSEventSink.testBadSimpleAppend only writes 57 events to the output as opposed to all 75. This can be verified by setting the environment variable hdfs_keepFiles or commenting out the tearDown method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-963) Add additional tests to TestHDFSEventSink and demystify existing tests

Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brock Noland updated FLUME-963:
-------------------------------

    Summary: Add additional tests to TestHDFSEventSink and demystify existing tests  (was: Add additional tes to TestHDFSEventSink and demystify existing tests)
    
> Add additional tests to TestHDFSEventSink and demystify existing tests
> ----------------------------------------------------------------------
>
>                 Key: FLUME-963
>                 URL: https://issues.apache.org/jira/browse/FLUME-963
>             Project: Flume
>          Issue Type: Bug
>          Components: Channel
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>             Fix For: v1.1.0
>
>         Attachments: FLUME-963-0.patch, FLUME-963-1.patch, FLUME-963-test-verify.patch
>
>
> TestHDFSEventSink.testBadSimpleAppend only writes 57 events to the output as opposed to all 75. This can be verified by setting the environment variable hdfs_keepFiles or commenting out the tearDown method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-963) Add additional tes to TestHDFSEventSink and demystify existing tests

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206258#comment-13206258 ] 

jiraposter@reviews.apache.org commented on FLUME-963:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3869/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

Adds verification to testAppend and testBadSimpleAppend.
Creates common verification method and changes all tests which output data to this method.
Changes testBadSimpleAppend to all events are processed by sink. 


This addresses bug FLUME-963.
    https://issues.apache.org/jira/browse/FLUME-963


Diffs
-----

  flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java 798028f 

Diff: https://reviews.apache.org/r/3869/diff


Testing
-------

Ran unit tests in this class in eclipse and all tests through maven.


Thanks,

Brock


                
> Add additional tes to TestHDFSEventSink and demystify existing tests
> --------------------------------------------------------------------
>
>                 Key: FLUME-963
>                 URL: https://issues.apache.org/jira/browse/FLUME-963
>             Project: Flume
>          Issue Type: Bug
>          Components: Channel
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>             Fix For: v1.1.0
>
>         Attachments: FLUME-963-test-verify.patch
>
>
> TestHDFSEventSink.testBadSimpleAppend only writes 57 events to the output as opposed to all 75. This can be verified by setting the environment variable hdfs_keepFiles or commenting out the tearDown method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-963) Add additional verifications to

Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brock Noland updated FLUME-963:
-------------------------------

    Summary: Add additional verifications to   (was: TestHDFSEventSink.testBadSimpleAppend when output verified)
    
> Add additional verifications to 
> --------------------------------
>
>                 Key: FLUME-963
>                 URL: https://issues.apache.org/jira/browse/FLUME-963
>             Project: Flume
>          Issue Type: Bug
>          Components: Channel
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>             Fix For: v1.1.0
>
>         Attachments: FLUME-963-test-verify.patch
>
>
> TestHDFSEventSink.testBadSimpleAppend only writes 57 events to the output as opposed to all 75. This can be verified by setting the environment variable hdfs_keepFiles or commenting out the tearDown method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (FLUME-963) Add additional tes to TestHDFSEventSink and demystify existing tests

Posted by "Arvind Prabhakar (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arvind Prabhakar reassigned FLUME-963:
--------------------------------------

    Assignee: Brock Noland
    
> Add additional tes to TestHDFSEventSink and demystify existing tests
> --------------------------------------------------------------------
>
>                 Key: FLUME-963
>                 URL: https://issues.apache.org/jira/browse/FLUME-963
>             Project: Flume
>          Issue Type: Bug
>          Components: Channel
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>             Fix For: v1.1.0
>
>         Attachments: FLUME-963-0.patch, FLUME-963-test-verify.patch
>
>
> TestHDFSEventSink.testBadSimpleAppend only writes 57 events to the output as opposed to all 75. This can be verified by setting the environment variable hdfs_keepFiles or commenting out the tearDown method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-963) Add additional tes to TestHDFSEventSink and demystify existing tests

Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brock Noland updated FLUME-963:
-------------------------------

    Attachment: FLUME-963-1.patch

Same patch but generated with --no-prefix option.
                
> Add additional tes to TestHDFSEventSink and demystify existing tests
> --------------------------------------------------------------------
>
>                 Key: FLUME-963
>                 URL: https://issues.apache.org/jira/browse/FLUME-963
>             Project: Flume
>          Issue Type: Bug
>          Components: Channel
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>             Fix For: v1.1.0
>
>         Attachments: FLUME-963-0.patch, FLUME-963-1.patch, FLUME-963-test-verify.patch
>
>
> TestHDFSEventSink.testBadSimpleAppend only writes 57 events to the output as opposed to all 75. This can be verified by setting the environment variable hdfs_keepFiles or commenting out the tearDown method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira