[GitHub] spark pull request #18106: [SPARK-20754][SQL] Support TRUNC (number)

[HyukjinKwon <gi...@git.apache.org>]

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18106#discussion_r130801952
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -1028,20 +1028,29 @@ def to_timestamp(col, format=None):
     
     
     @since(1.5)
    -def trunc(date, format):
    +def trunc(data, truncParam):
    --- End diff --
    
    @wangyum, would you mind revert this renaming? This breaks the compatibility if user script calls this by
    
    ```python
    trunc(..., format= ...)
    trunc(date=..., format= ...)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org