You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "bvolpato (via GitHub)" <gi...@apache.org> on 2023/11/13 00:26:48 UTC

[PR] Add getters to CheckResult in IT framework [beam]

bvolpato opened a new pull request, #29411:
URL: https://github.com/apache/beam/pull/29411

   I want to use the checker in a specific way, and we didn't expose the `success` or `message`:
   
   ```java
       assertThat(pubsubCheck.check().isSuccess()).isTrue();
   ```
   
   Right now we only have `pubsubCheck.get()` but it's not expressive enough (and wouldn't return the message if it failed).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add getters to CheckResult in IT framework [beam]

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.

bvolpato commented on PR #29411:
URL: https://github.com/apache/beam/pull/29411#issuecomment-1807492853

   Thanks @lostluck. Please merge when convenient 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add getters to CheckResult in IT framework [beam]

Posted by "lostluck (via GitHub)" <gi...@apache.org>.

lostluck merged PR #29411:
URL: https://github.com/apache/beam/pull/29411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add getters to CheckResult in IT framework [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #29411:
URL: https://github.com/apache/beam/pull/29411#issuecomment-1807314838

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @lostluck added as fallback since no labels match configuration
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org