You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/06/01 18:36:52 UTC
[kudu-CR](branch-1.17.x) jwt: plumb JWT into mini cluster
Hello Kudu Jenkins, Wenzhe Zhou,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19968
to review the following change.
Change subject: jwt: plumb JWT into mini cluster
......................................................................
jwt: plumb JWT into mini cluster
This patch adds options to ExternalMiniCluster to start a MiniOidc
alongside the calling process.
Co-authored-by: Andrew Wong <aw...@apache.org>
Change-Id: Id0d3e53b60933ada0194afbe0ad4775be649b653
Reviewed-on: http://gerrit.cloudera.org:8080/18475
Tested-by: Kudu Jenkins
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 2a02969e5c186b22f1bf89555f184680eaf31ca0)
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rpc/negotiation.cc
M src/kudu/server/server_base.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/jwt-util.cc
A src/kudu/util/jwt_test_certs.cc
M src/kudu/util/jwt_test_certs.h
M src/kudu/util/mini_oidc.cc
11 files changed, 471 insertions(+), 314 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/19968/1
--
To view, visit http://gerrit.cloudera.org:8080/19968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0d3e53b60933ada0194afbe0ad4775be649b653
Gerrit-Change-Number: 19968
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR](branch-1.17.x) jwt: plumb JWT into mini cluster
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19968 )
Change subject: jwt: plumb JWT into mini cluster
......................................................................
Patch Set 1: Code-Review+2
This is needed for https://gerrit.cloudera.org/#/c/19970
Since Yingchun added +2 for the latter, I assume this is supposed to be pushed as well.
--
To view, visit http://gerrit.cloudera.org:8080/19968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0d3e53b60933ada0194afbe0ad4775be649b653
Gerrit-Change-Number: 19968
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Jun 2023 16:21:27 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) jwt: plumb JWT into mini cluster
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: jwt: plumb JWT into mini cluster
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id0d3e53b60933ada0194afbe0ad4775be649b653
Gerrit-Change-Number: 19968
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR](branch-1.17.x) jwt: plumb JWT into mini cluster
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19968 )
Change subject: jwt: plumb JWT into mini cluster
......................................................................
Patch Set 1: Code-Review+1
unrelated test failure (TSAN)
--
To view, visit http://gerrit.cloudera.org:8080/19968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0d3e53b60933ada0194afbe0ad4775be649b653
Gerrit-Change-Number: 19968
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Jun 2023 16:18:29 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) jwt: plumb JWT into mini cluster
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19968 )
Change subject: jwt: plumb JWT into mini cluster
......................................................................
Patch Set 1: Verified+1 -Code-Review
--
To view, visit http://gerrit.cloudera.org:8080/19968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0d3e53b60933ada0194afbe0ad4775be649b653
Gerrit-Change-Number: 19968
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Jun 2023 16:18:56 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) jwt: plumb JWT into mini cluster
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19968 )
Change subject: jwt: plumb JWT into mini cluster
......................................................................
jwt: plumb JWT into mini cluster
This patch adds options to ExternalMiniCluster to start a MiniOidc
alongside the calling process.
Co-authored-by: Andrew Wong <aw...@apache.org>
Change-Id: Id0d3e53b60933ada0194afbe0ad4775be649b653
Reviewed-on: http://gerrit.cloudera.org:8080/18475
Tested-by: Kudu Jenkins
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 2a02969e5c186b22f1bf89555f184680eaf31ca0)
Reviewed-on: http://gerrit.cloudera.org:8080/19968
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/rpc/negotiation.cc
M src/kudu/server/server_base.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/jwt-util.cc
A src/kudu/util/jwt_test_certs.cc
M src/kudu/util/jwt_test_certs.h
M src/kudu/util/mini_oidc.cc
11 files changed, 471 insertions(+), 314 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0d3e53b60933ada0194afbe0ad4775be649b653
Gerrit-Change-Number: 19968
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>