You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by be...@apache.org on 2024/01/02 18:06:18 UTC
(lucene) branch main updated: Reduce number of dimensions for Test[Byte|Float]VectorSimilarityQuery (#12988)
This is an automated email from the ASF dual-hosted git repository.
benwtrent pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/lucene.git
The following commit(s) were added to refs/heads/main by this push:
new 248f067d520 Reduce number of dimensions for Test[Byte|Float]VectorSimilarityQuery (#12988)
248f067d520 is described below
commit 248f067d5207da653f94751eb5d4e8a42ae1238e
Author: Kaival Parikh <46...@users.noreply.github.com>
AuthorDate: Tue Jan 2 23:36:12 2024 +0530
Reduce number of dimensions for Test[Byte|Float]VectorSimilarityQuery (#12988)
### Description
Identified in #12955, where `TestFloatVectorSimilarityQuery.testVectorsAboveSimilarity` fails because of a disconnected HNSW graph
This is a bigger issue, but we can reduce intermittent failures by keeping the number of docs and dimensions same as [`BaseKnnVectorQueryTestCase.testRandom`](https://github.com/apache/lucene/blob/dc9f154aa574e8cd0e60070a1814c1d221fbec5d/lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java#L470) (similar test for KNN with random vectors)
### Command to reproduce
```
./gradlew :lucene:core:test --tests "org.apache.lucene.search.TestFloatVectorSimilarityQuery.testVectorsAboveSimilarity" -Ptests.jvms=12 -Ptests.jvmargs= -Ptests.seed=1A1CDC0974AF361
```
---
.../test/org/apache/lucene/search/TestByteVectorSimilarityQuery.java | 2 +-
.../test/org/apache/lucene/search/TestFloatVectorSimilarityQuery.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lucene/core/src/test/org/apache/lucene/search/TestByteVectorSimilarityQuery.java b/lucene/core/src/test/org/apache/lucene/search/TestByteVectorSimilarityQuery.java
index e2855999b44..07f9e8a86e9 100644
--- a/lucene/core/src/test/org/apache/lucene/search/TestByteVectorSimilarityQuery.java
+++ b/lucene/core/src/test/org/apache/lucene/search/TestByteVectorSimilarityQuery.java
@@ -33,7 +33,7 @@ public class TestByteVectorSimilarityQuery
idField = getClass().getSimpleName() + ":IdField";
function = VectorSimilarityFunction.EUCLIDEAN;
numDocs = atLeast(100);
- dim = atLeast(50);
+ dim = atLeast(5);
}
@Override
diff --git a/lucene/core/src/test/org/apache/lucene/search/TestFloatVectorSimilarityQuery.java b/lucene/core/src/test/org/apache/lucene/search/TestFloatVectorSimilarityQuery.java
index 9fe2d5965d2..479d4ef0df1 100644
--- a/lucene/core/src/test/org/apache/lucene/search/TestFloatVectorSimilarityQuery.java
+++ b/lucene/core/src/test/org/apache/lucene/search/TestFloatVectorSimilarityQuery.java
@@ -33,7 +33,7 @@ public class TestFloatVectorSimilarityQuery
idField = getClass().getSimpleName() + ":IdField";
function = VectorSimilarityFunction.EUCLIDEAN;
numDocs = atLeast(100);
- dim = atLeast(50);
+ dim = atLeast(5);
}
@Override