You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "Josephblt (via GitHub)" <gi...@apache.org> on 2024/05/23 11:49:39 UTC
[PR] NO-ISSUE: Misleading forms [incubator-kie-tools]
Josephblt opened a new pull request, #2361:
URL: https://github.com/apache/incubator-kie-tools/pull/2361
Done:
Created info icon and tooltip
Next steps:
Set tooltip content for Collection constraint
Set tooltip content for Collection item constraint
This is what the UI looks like with the information icons:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Misleading forms [incubator-kie-tools]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on PR #2361:
URL: https://github.com/apache/incubator-kie-tools/pull/2361#issuecomment-2128711084
I personally agree with @yesamer [comment](https://github.com/apache/incubator-kie-tools/pull/2361#issuecomment-2128645243).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Misleading forms [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2361:
URL: https://github.com/apache/incubator-kie-tools/pull/2361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Misleading forms [incubator-kie-tools]
Posted by "Josephblt (via GitHub)" <gi...@apache.org>.
Josephblt commented on PR #2361:
URL: https://github.com/apache/incubator-kie-tools/pull/2361#issuecomment-2129124832
Hello @yesamer, @gitgabrio. I agree, the blue hints are way nicer but in the end, less is more, and the extra colors are just unnecessary detail. As for the headers I tried to go with a full dev look here. But, just as with the colors, it is a little over the top. Here is the final version with your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Misleading forms [incubator-kie-tools]
Posted by "Josephblt (via GitHub)" <gi...@apache.org>.
Josephblt commented on PR #2361:
URL: https://github.com/apache/incubator-kie-tools/pull/2361#issuecomment-2127757850
Hello @tiagobento, @gitgabrio, @baldimir, @jomarko @yesamer. I would appreciate your opinion on the style of the tooltips.
Here are the two options:
1. Blue icon and title.
2. Black icon and tile.
Also, please feel free to suggest any changes in the content of the tooltips or anything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Misleading forms [incubator-kie-tools]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on PR #2361:
URL: https://github.com/apache/incubator-kie-tools/pull/2361#issuecomment-2129163411
@Josephblt Fine for me
(side-note: force-push is a gh-smell)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Misleading forms [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on PR #2361:
URL: https://github.com/apache/incubator-kie-tools/pull/2361#issuecomment-2128645243
Hi @Josephblt,
I like option 1. , but probably option 2. is more consistent with the current editor style. So, I vote for option 2.
I think that having that (aka itemDefinition#allowedValue) it's a technicality not so useful for the end user. I guess nobody will use the xsd as a reference, the goal here is to give a reference for the documentation.
So, I'd change that to `Collection constraint (Type Constraint)` and `Collection item constraint (Allowed Values)` or similar.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Misleading forms [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2361:
URL: https://github.com/apache/incubator-kie-tools/pull/2361#issuecomment-2127219746
@Josephblt Looks good, now we're just missing the text.. Would be good to have a screenshot of the popups open too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org