You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by David Lecomber <ds...@ts.com> on 2001/09/14 18:21:06 UTC

StandardManager : Session expiry thread.

[tomcat 4.0-rc2] It's possible for the session expiring thread to not
catch an exception - thrown within session.expire - which then stops
this thread and means all other sessions are not expired (forever!)

        at org.apache.catalina.session.StandardSession.removeAttribute(StandardSession.java:XX)
        at org.apache.catalina.session.StandardSession.expire(StandardSession.java:XX)
        at org.apache.catalina.session.StandardManager.processExpires(StandardManager.java:XX)
        at org.apache.catalina.session.StandardManager.run(StandardManager.java:XX)
        at java.lang.Thread.run(Thread.java:484)
 
I'd like to suggest an obvious patch to this -- a try/catch 
within/around removeAttribute or expire.  As it's day one of me
reading this mailing list, and even contemplating submitting a patch,
does anyone have opinions regarding the preferred fix?

Cheers
David

Re: StandardManager : Session expiry thread.

Posted by "Craig R. McClanahan" <cr...@apache.org>.

On Fri, 14 Sep 2001, David Lecomber wrote:

> Date: Fri, 14 Sep 2001 17:21:06 +0100
> From: David Lecomber <ds...@ts.com>
> Reply-To: tomcat-dev@jakarta.apache.org, dsl@ts.com
> To: tomcat-dev@jakarta.apache.org
> Subject: StandardManager : Session expiry thread.
>
> [tomcat 4.0-rc2] It's possible for the session expiring thread to not
> catch an exception - thrown within session.expire - which then stops
> this thread and means all other sessions are not expired (forever!)
>
>         at org.apache.catalina.session.StandardSession.removeAttribute(StandardSession.java:XX)
>         at org.apache.catalina.session.StandardSession.expire(StandardSession.java:XX)
>         at org.apache.catalina.session.StandardManager.processExpires(StandardManager.java:XX)
>         at org.apache.catalina.session.StandardManager.run(StandardManager.java:XX)
>         at java.lang.Thread.run(Thread.java:484)
>
> I'd like to suggest an obvious patch to this -- a try/catch
> within/around removeAttribute or expire.  As it's day one of me
> reading this mailing list, and even contemplating submitting a patch,
> does anyone have opinions regarding the preferred fix?
>

Just a thank you for your sharp eyes!  I sure love open source ...

> Cheers
> David
>

Craig