You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by alexlehm <gi...@git.apache.org> on 2017/03/04 14:46:15 UTC

[GitHub] storm pull request #1990: I have tried to improve the page about symlinks in...

GitHub user alexlehm opened a pull request:

    https://github.com/apache/storm/pull/1990

    I have tried to improve the page about symlinks in Windows

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alexlehm/storm doc-improve-windows-symlink

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1990.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1990
    
----
commit ba7b18a6ac80d2782a2953e154abc854d40ae808
Author: alexlehm <al...@gmail.com>
Date:   2017-03-03T23:10:52Z

    I have tried to improve the page about symlinks in Windows, this had me completely stumped when i tried to run Storm for the first time since the symlink permissions are not supported in some (non-professional) Windows versions.
    
    Signed-off-by: alexlehm <al...@gmail.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1990: I have tried to improve the page about symlinks in Window...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1990
  
    @alexlehm Thanks for contribution, I merged this to master, 1.x, 1.0.x branches.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1990: I have tried to improve the page about symlinks in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1990


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1990: I have tried to improve the page about symlinks in Window...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1990
  
    @alexlehm 
    The updated explanation looks good. 
    Please split commit message by title and body, and leave only abstraction for the change. You can rebase or amend the commit and force push.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1990: I have tried to improve the page about symlinks in Window...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1990
  
    @alexlehm Thanks. This is exactly what I want. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1990: I have tried to improve the page about symlinks in Window...

Posted by alexlehm <gi...@git.apache.org>.
Github user alexlehm commented on the issue:

    https://github.com/apache/storm/pull/1990
  
    not complete sure it that is what you mean, I changed the commit message a bit



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---