[GitHub] Fokko edited a comment on issue #4283: [AIRFLOW-3450] Remove unnecessary sigint handler

[GitBox <gi...@apache.org>]

Fokko edited a comment on issue #4283: [AIRFLOW-3450] Remove unnecessary sigint handler
URL: https://github.com/apache/incubator-airflow/pull/4283#issuecomment-444676536
 
 
   I'm running Docker (Cloud composer), but I don't get any explicit reason:
   ```
   [2018-12-05 20:20:57,138] {jobs.py:401} ERROR - Got an exception! Propagating...
   Traceback (most recent call last):
     File "/usr/local/lib/airflow/airflow/jobs.py", line 376, in helper
       settings.configure_orm()
     File "/usr/local/lib/airflow/airflow/settings.py", line 180, in configure_orm
       engine = create_engine(SQL_ALCHEMY_CONN, **engine_args)
     File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/__init__.py", line 391, in create_engine
       return strategy.create(*args, **kwargs)
     File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/strategies.py", line 162, in create
       engine = engineclass(pool, dialect, u, **engine_args)
     File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1772, in __init__
       self.echo = echo
     File "/usr/local/lib/python3.6/site-packages/sqlalchemy/log.py", line 217, in __set__
       instance_logger(instance, echoflag=value)
     File "/usr/local/lib/python3.6/site-packages/sqlalchemy/log.py", line 173, in instance_logger
       def instance_logger(instance, echoflag=None):
     File "/usr/local/lib/airflow/airflow/bin/cli.py", line 85, in sigint_handler
       sys.exit(0)
   ```
   So my initial thought was to just let the exception propagate. Also the K8s tests are still running fine :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services