You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by skonto <gi...@git.apache.org> on 2018/04/03 15:01:30 UTC

[GitHub] spark pull request #20967: [SPARK-23857][Mesos] remove keytab check in mesos...

GitHub user skonto opened a pull request:

    https://github.com/apache/spark/pull/20967

    [SPARK-23857][Mesos] remove keytab check in mesos cluster mode at first submit time

    ## What changes were proposed in this pull request?
    - Removes the check for the keytab when we are running in mesos cluster mode.
    - Keeps the check for client mode since in cluster mode we eventually launch the driver within the cluster in client mode. In the latter case we want to have the check done when the container starts, the keytab should be checked if it exists within the containers local filesystem. 
    
    ## How was this patch tested?
    
    This was manually tested by running spark submit in mesos cluster mode.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skonto/spark fix_mesos_keytab_susbmit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20967.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20967
    
----
commit 5bade04d973fa1176f906147b7387caab2b3a812
Author: Stavros <st...@...>
Date:   2018-04-03T14:58:21Z

    remove keytab check in mesos cluster mode at first submit time

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20967: [SPARK-23857][Mesos] remove keytab check in mesos cluste...

Posted by skonto <gi...@git.apache.org>.

Github user skonto commented on the issue:

    https://github.com/apache/spark/pull/20967
  
    @srowen Yes. We have seen this as a restriction causing problems to customers. For example one customer wanted to do a spark-submit in cluster mode and keytab was retrieved from secret store.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20967: [SPARK-23857][Mesos] remove keytab check in mesos cluste...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/20967
  
    Is this one still active?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20967: [SPARK-23857][Mesos] remove keytab check in mesos cluste...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20967
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20967: [SPARK-23857][Mesos] remove keytab check in mesos cluste...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20967
  
    **[Test build #4185 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4185/testReport)** for PR 20967 at commit [`5bade04`](https://github.com/apache/spark/commit/5bade04d973fa1176f906147b7387caab2b3a812).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20967: [SPARK-23857][Mesos] remove keytab check in mesos cluste...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20967
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20967: [SPARK-23857][Mesos] remove keytab check in mesos cluste...

Posted by skonto <gi...@git.apache.org>.

Github user skonto commented on the issue:

    https://github.com/apache/spark/pull/20967
  
    @susanxhuynh pls review.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20967: [SPARK-23857][Mesos] remove keytab check in mesos cluste...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/20967
  
    Merged to master


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20967: [SPARK-23857][Mesos] remove keytab check in mesos cluste...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20967
  
    **[Test build #88839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88839/testReport)** for PR 20967 at commit [`5bade04`](https://github.com/apache/spark/commit/5bade04d973fa1176f906147b7387caab2b3a812).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20967: [SPARK-23857][Mesos] remove keytab check in mesos cluste...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20967
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88839/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20967: [SPARK-23857][Mesos] remove keytab check in mesos cluste...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20967
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1914/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20967: [SPARK-23857][Mesos] remove keytab check in mesos cluste...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20967
  
    **[Test build #4185 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4185/testReport)** for PR 20967 at commit [`5bade04`](https://github.com/apache/spark/commit/5bade04d973fa1176f906147b7387caab2b3a812).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org