You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/07/16 13:04:03 UTC
[PR] feat(cli): support vsr and enable the CLI suite under server-ng [iggy]
hubcio opened a new pull request, #3679:
URL: https://github.com/apache/iggy/pull/3679
The CLI integration suite was gated off under the vsr feature, so
the `iggy` CLI was never exercised against server-ng. Enabling it
surfaced real gaps that this change fixes.
Un-gate the suite and add a `vsr` feature to iggy-cli; the
server-ng Docker image now builds with `--features vsr`.
Creating a topic (or partitions) with a zero partition count
aborted shard-0 on server-ng: the allocator's `.expect()` on the
highest consensus-group id panicked when no partitions were
assigned, taking the whole process down with SIGABRT. This was
client-triggerable. Skip the observe call when the assignment set
is empty.
The stats response hardcoded free/total disk space to 0. Resolve
both from the server's data path via fs2.
Harden the harness port reserver against a cross-process race.
`RESERVED_PORTS` dedups only within a process, but nextest runs
each test in its own process; concurrent 3-node startups raced for
the same ephemeral port at the release->bind window and failed with
CannotBindToSocket. Claim each port with an exclusive advisory file
lock held for the process lifetime, making the claim visible across
processes; the OS drops it on exit so a crash never leaks a port.
A few CLI cases are mode-split where server-ng diverges from legacy
by design: flush returns FeatureUnavailable, the session-timeout
message differs, and purge is eventually consistent so server state
is polled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(cli): support vsr and enable the CLI suite under server-ng [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski merged PR #3679:
URL: https://github.com/apache/iggy/pull/3679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(cli): support vsr and enable the CLI suite under server-ng [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3679:
URL: https://github.com/apache/iggy/pull/3679#issuecomment-4992203990
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3679?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 72.46%. Comparing base ([`2e56b5f`](https://app.codecov.io/gh/apache/iggy/commit/2e56b5fc0b6d2776936d995190544e5b3062e2b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5c45136`](https://app.codecov.io/gh/apache/iggy/commit/5c45136e7a0e1013e2d10ad3b80b1f580891cc31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3679 +/- ##
============================================
- Coverage 73.99% 72.46% -1.54%
Complexity 937 937
============================================
Files 1301 1238 -63
Lines 147354 142656 -4698
Branches 122914 122814 -100
============================================
- Hits 109034 103373 -5661
- Misses 34849 35899 +1050
+ Partials 3471 3384 -87
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/3679/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3679/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.29% <ø> (+<0.01%)` | :arrow_up: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3679/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.44% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3679/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.21% <ø> (ø)` | |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3679/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.17% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3679/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.29% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3679/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.27% <ø> (-4.08%)` | :arrow_down: |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3679/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.94% <ø> (-25.78%)` | :arrow_down: |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3679?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/metadata/src/impls/metadata.rs](https://app.codecov.io/gh/apache/iggy/pull/3679?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fimpls%2Fmetadata.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvaW1wbHMvbWV0YWRhdGEucnM=) | `50.98% <ø> (+0.23%)` | :arrow_up: |
| [core/server-ng/src/bootstrap.rs](https://app.codecov.io/gh/apache/iggy/pull/3679?src=pr&el=tree&filepath=core%2Fserver-ng%2Fsrc%2Fbootstrap.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXItbmcvc3JjL2Jvb3RzdHJhcC5ycw==) | `11.18% <ø> (ø)` | |
| [core/server-ng/src/responses.rs](https://app.codecov.io/gh/apache/iggy/pull/3679?src=pr&el=tree&filepath=core%2Fserver-ng%2Fsrc%2Fresponses.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXItbmcvc3JjL3Jlc3BvbnNlcy5ycw==) | `40.13% <ø> (+0.16%)` | :arrow_up: |
... and [123 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3679/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org