You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/01/09 14:23:19 UTC
Review Request 55341: Add secure znode command for ambari infra solr
client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55341/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-19425
https://issues.apache.org/jira/browse/AMBARI-19425
Repository: ambari
Description
-------
add 2 new commands for solr-client:
1. secure znode: set 'cdrwa' acl for specific sasl users, and set 'r' acl for world.
2. secure solr znode: set 'cdrwa' acl for specific sasl users (solr), but skip znode/configs and znode/collections znodes (set those to 'cr' acl)
the patch does not contain the usage of these commands. also i removed some unused commands.
- the second command will be used inside infra-solr ambari integration code, during start
- in logsearch, acls will be setup inside the logsearch code instead of use it in ambari integration code.
- for atlas/ranger it will be used inside ambari integration code, later it would be better to use inside atlas/ranger code (same as for logsearch)
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 521c9c6
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java 6035c86
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java 20096fe
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java bad622b
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CopyZnodeZkCommand.java a202930
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateSaslUsersZkCommand.java 1c25b9f
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/SecureZNodeZkCommand.java cdc3ebf
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java 23e5fb3
Diff: https://reviews.apache.org/r/55341/diff/
Testing
-------
testing done. (manually)
Thanks,
Oliver Szabo
Re: Review Request 55341: Add secure znode command for ambari infra
solr client
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55341/#review160894
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java (line 70)
<https://reviews.apache.org/r/55341/#comment232135>
either check for null, or don't check at all, if it's surely not null then you can just as well iterate over an empty list
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java (line 76)
<https://reviews.apache.org/r/55341/#comment232136>
either check for null, or don't check at all, if it's surely not null then you can just as well iterate over an empty list
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java (line 82)
<https://reviews.apache.org/r/55341/#comment232137>
Map.values() return the all of them at once, no need to iterate, just addAll
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java (line 88)
<https://reviews.apache.org/r/55341/#comment232138>
rename it to createActListFromSaslUsers, get suggests that it is getting some kind of information from the parameters
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java (line 103)
<https://reviews.apache.org/r/55341/#comment232134>
typo: exclustePath -> excludePath
- Miklos Gergely
On Jan. 9, 2017, 2:28 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55341/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 2:28 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-19425
> https://issues.apache.org/jira/browse/AMBARI-19425
>
>
> Repository: ambari
>
>
> Description
> -------
>
> add 2 new commands for solr-client:
> 1. secure znode: set 'cdrwa' acl for specific sasl users, and set 'r' acl for world.
> 2. secure solr znode: set 'cdrwa' acl for specific sasl users (solr), but skip znode/configs and znode/collections znodes (set those to 'cr' acl)
>
> the patch does not contain the usage of these commands. also i removed some unused commands.
>
> - the second command will be used inside infra-solr ambari integration code, during start
> - in logsearch, acls will be setup inside the logsearch code instead of use it in ambari integration code.
> - for atlas/ranger it will be used inside ambari integration code, later it would be better to use inside atlas/ranger code (same as for logsearch)
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 521c9c6
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java 6035c86
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java 20096fe
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java bad622b
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CopyZnodeZkCommand.java a202930
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateSaslUsersZkCommand.java 1c25b9f
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/SecureZNodeZkCommand.java cdc3ebf
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java 23e5fb3
>
> Diff: https://reviews.apache.org/r/55341/diff/
>
>
> Testing
> -------
>
> testing done. (manually)
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 55341: Add secure znode command for ambari infra
solr client
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55341/#review160996
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Jan. 9, 2017, 3:21 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55341/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 3:21 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-19425
> https://issues.apache.org/jira/browse/AMBARI-19425
>
>
> Repository: ambari
>
>
> Description
> -------
>
> add 2 new commands for solr-client:
> 1. secure znode: set 'cdrwa' acl for specific sasl users, and set 'r' acl for world.
> 2. secure solr znode: set 'cdrwa' acl for specific sasl users (solr), but skip znode/configs and znode/collections znodes (set those to 'cr' acl)
>
> the patch does not contain the usage of these commands. also i removed some unused commands.
>
> - the second command will be used inside infra-solr ambari integration code, during start
> - in logsearch, acls will be setup inside the logsearch code instead of use it in ambari integration code.
> - for atlas/ranger it will be used inside ambari integration code, later it would be better to use inside atlas/ranger code (same as for logsearch)
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 521c9c6
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java 6035c86
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java 20096fe
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java bad622b
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CopyZnodeZkCommand.java a202930
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateSaslUsersZkCommand.java 1c25b9f
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/SecureSolrZNodeZkCommand.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/SecureZNodeZkCommand.java cdc3ebf
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java 23e5fb3
>
> Diff: https://reviews.apache.org/r/55341/diff/
>
>
> Testing
> -------
>
> testing done. (manually)
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 55341: Add secure znode command for ambari infra
solr client
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55341/
-----------------------------------------------------------
(Updated Jan. 9, 2017, 3:21 p.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Changes
-------
fixed typo and iterations + rename function
Bugs: AMBARI-19425
https://issues.apache.org/jira/browse/AMBARI-19425
Repository: ambari
Description
-------
add 2 new commands for solr-client:
1. secure znode: set 'cdrwa' acl for specific sasl users, and set 'r' acl for world.
2. secure solr znode: set 'cdrwa' acl for specific sasl users (solr), but skip znode/configs and znode/collections znodes (set those to 'cr' acl)
the patch does not contain the usage of these commands. also i removed some unused commands.
- the second command will be used inside infra-solr ambari integration code, during start
- in logsearch, acls will be setup inside the logsearch code instead of use it in ambari integration code.
- for atlas/ranger it will be used inside ambari integration code, later it would be better to use inside atlas/ranger code (same as for logsearch)
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 521c9c6
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java 6035c86
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java 20096fe
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java bad622b
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CopyZnodeZkCommand.java a202930
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateSaslUsersZkCommand.java 1c25b9f
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/SecureSolrZNodeZkCommand.java PRE-CREATION
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/SecureZNodeZkCommand.java cdc3ebf
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java 23e5fb3
Diff: https://reviews.apache.org/r/55341/diff/
Testing
-------
testing done. (manually)
Thanks,
Oliver Szabo
Re: Review Request 55341: Add secure znode command for ambari infra
solr client
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55341/
-----------------------------------------------------------
(Updated Jan. 9, 2017, 2:28 p.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Changes
-------
fixed typo
Bugs: AMBARI-19425
https://issues.apache.org/jira/browse/AMBARI-19425
Repository: ambari
Description
-------
add 2 new commands for solr-client:
1. secure znode: set 'cdrwa' acl for specific sasl users, and set 'r' acl for world.
2. secure solr znode: set 'cdrwa' acl for specific sasl users (solr), but skip znode/configs and znode/collections znodes (set those to 'cr' acl)
the patch does not contain the usage of these commands. also i removed some unused commands.
- the second command will be used inside infra-solr ambari integration code, during start
- in logsearch, acls will be setup inside the logsearch code instead of use it in ambari integration code.
- for atlas/ranger it will be used inside ambari integration code, later it would be better to use inside atlas/ranger code (same as for logsearch)
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 521c9c6
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java 6035c86
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java 20096fe
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java bad622b
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CopyZnodeZkCommand.java a202930
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateSaslUsersZkCommand.java 1c25b9f
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/SecureZNodeZkCommand.java cdc3ebf
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java 23e5fb3
Diff: https://reviews.apache.org/r/55341/diff/
Testing
-------
testing done. (manually)
Thanks,
Oliver Szabo