You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2011/10/09 19:53:46 UTC

svn commit: r1180670 - /james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java

Author: norman
Date: Sun Oct  9 17:53:46 2011
New Revision: 1180670

URL: http://svn.apache.org/viewvc?rev=1180670&view=rev
Log:
Declare some fields final

Modified:
    james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java

Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java?rev=1180670&r1=1180669&r2=1180670&view=diff
==============================================================================
--- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java (original)
+++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java Sun Oct  9 17:53:46 2011
@@ -50,15 +50,15 @@ import org.apache.james.mailbox.UpdatedF
  */
 public class SelectedMailboxImpl implements SelectedMailbox, MailboxListener{
 
-    private final Set<Long> recentUids;
+    private final Set<Long> recentUids = new TreeSet<Long>();
 
-    private boolean recentUidRemoved;
+    private boolean recentUidRemoved = false;
 
     private MailboxManager mailboxManager;
 
     private MailboxPath path;
 
-    private ImapSession session;
+    private final ImapSession session;
     
 
     private final static Flags FLAGS = new Flags();
@@ -71,9 +71,9 @@ public class SelectedMailboxImpl impleme
     }
     
     private final long sessionId;
-    private Set<Long> flagUpdateUids;
-    private Flags.Flag uninterestingFlag;
-    private Set<Long> expungedUids;
+    private final Set<Long> flagUpdateUids = new TreeSet<Long>();;
+    private final Flags.Flag uninterestingFlag = Flags.Flag.RECENT;
+    private final Set<Long> expungedUids = new TreeSet<Long>();
 
     private boolean isDeletedByOtherSession = false;
     private boolean sizeChanged = false;
@@ -81,33 +81,22 @@ public class SelectedMailboxImpl impleme
     private Flags applicableFlags;
     private boolean applicableFlagsChanged;
     
-    private SortedMap<Integer, Long> msnToUid;
+    private final SortedMap<Integer, Long> msnToUid =new TreeMap<Integer, Long>();;
 
-    private SortedMap<Long, Integer> uidToMsn;
+    private final SortedMap<Long, Integer> uidToMsn = new TreeMap<Long, Integer>();
 
     private long highestUid = 0;
 
     private int highestMsn = 0;
     
     public SelectedMailboxImpl(final MailboxManager mailboxManager, final ImapSession session, final MailboxPath path) throws MailboxException {
-        recentUids = new TreeSet<Long>();
-        recentUidRemoved = false;
         this.session = session;
         this.sessionId = ImapSessionUtils.getMailboxSession(session).getSessionId();
-        flagUpdateUids = new TreeSet<Long>();
-        expungedUids = new TreeSet<Long>();
-        uninterestingFlag = Flags.Flag.RECENT;
         this.mailboxManager = mailboxManager;
         
         // Ignore events from our session
         setSilentFlagChanges(true);
         this.path = path;
-        this.session = session;
-
-        msnToUid = new TreeMap<Integer, Long>();
-        uidToMsn = new TreeMap<Long, Integer>();
-
-        
         init();
     }
  
@@ -210,7 +199,6 @@ public class SelectedMailboxImpl impleme
         msnToUid.clear();
         flagUpdateUids.clear();
 
-        uninterestingFlag = null;
         expungedUids.clear();
         recentUids.clear();
         MailboxSession mailboxSession = ImapSessionUtils.getMailboxSession(session);



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org