[GitHub] [phoenix] kadirozde commented on a change in pull request #701: PHOENIX-5709 Simplify index update generation code for consistent glo…

[GitBox <gi...@apache.org>]

kadirozde commented on a change in pull request #701: PHOENIX-5709 Simplify index update generation code for consistent glo…
URL: https://github.com/apache/phoenix/pull/701#discussion_r387861951
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
 ##########
 @@ -1272,6 +1272,9 @@ private static Put prepareIndexPutForRebuid(IndexMaintainer indexMaintainer, Imm
             byte[] indexRowKey = indexMaintainer.buildRowKey(mergedRowVG, rowKeyPtr,
                     null, null, HConstants.LATEST_TIMESTAMP);
             indexPut = new Put(indexRowKey);
+        } else {
+            removeEmptyColumn(indexPut, indexMaintainer.getEmptyKeyValueFamily().copyBytesIfNecessary(),
 
 Review comment:
   There is no HBase client API to change the value of a cell. In order to change the value of the empty column cell, we need to remove it from the mutation and add a new cell with the new value (here the verify status). I will add a comment like this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services