You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Eelco Hillenius (JIRA)" <ji...@apache.org> on 2008/10/13 03:08:44 UTC
[jira] Created: (WICKET-1868) i18n package resource resolving
depends too much on available locale
i18n package resource resolving depends too much on available locale
--------------------------------------------------------------------
Key: WICKET-1868
URL: https://issues.apache.org/jira/browse/WICKET-1868
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-M3, 1.3.4
Reporter: Eelco Hillenius
Assignee: Eelco Hillenius
Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639226#action_12639226 ]
Eelco Hillenius commented on WICKET-1868:
-----------------------------------------
running from Windows I see
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-1868.
----------------------------------------
Resolution: Fixed
applied patch to 1.4-rc2. From the comments I understand it has been applied to 1.3 already.
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.6, 1.4-RC2
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639222#action_12639222 ]
Igor Vaynberg commented on WICKET-1868:
---------------------------------------
hold on, i am rerunning the tests, will attach the results in a sec so you guys see what i see
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639228#action_12639228 ]
Igor Vaynberg commented on WICKET-1868:
---------------------------------------
interesting.
looking into teamcity logs i can see your commit did not break 1.3.x, but it did break trunk. you think this is a jdk5/6 issue?
http://wicketstuff.org/teamcity/viewLog.html?tab=buildResultsDiv&buildTypeId=bt2&buildId=1970
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1868:
----------------------------------
Fix Version/s: 1.4-RC2
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.6, 1.4-RC2
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675442#action_12675442 ]
Igor Vaynberg commented on WICKET-1868:
---------------------------------------
applied in:
*728321 12/20/08 9:48 AM 4 jdonnerstag wicket-1868: i18n package resource resolving depends too much on available locale
Juergen, can you put the jira key in the comment capitalized - WICKET-1868 instead of wicket-1868 - that way jira's svn plugin can properly relate the issue to the commit. thanks!
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.6, 1.4-RC2
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639225#action_12639225 ]
Igor Vaynberg commented on WICKET-1868:
---------------------------------------
the test log is from wicket trunk
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639234#action_12639234 ]
Igor Vaynberg commented on WICKET-1868:
---------------------------------------
i reapplied the change to wicket-1.3.x since it seems to work there fine. can you see why trunk is freaking out?
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639233#action_12639233 ]
Eelco Hillenius commented on WICKET-1868:
-----------------------------------------
Aw, dang, you're right. It's not a jdk5/6 issues, because they fail on jdk5 here as well. I guess I only tested on the 1.3 branch assuming that the fix was so local it wouldn't have a consequence for trunk. The interesting part of course is why that matters so much.
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1868:
-------------------------------------
Fix Version/s: (was: 1.4-M4)
(was: 1.3.5)
1.3.6
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.6
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639215#action_12639215 ]
Eelco Hillenius commented on WICKET-1868:
-----------------------------------------
There were three unit tests in WebResponseExceptionsTest broken before I started working on the fix, and those three are still broken. I just ran tests in Eclipse again, and everything else passes. I didn't try maven as I'm out of time due to issues I'm trying to track with disksessionstore
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639213#action_12639213 ]
Johan Compagner commented on WICKET-1868:
-----------------------------------------
i also didnt encounter broken tests.
I was running the tests just befor and after i updated the rollback but this didnt result in other test results for me.
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639237#action_12639237 ]
Eelco Hillenius commented on WICKET-1868:
-----------------------------------------
I'll try
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639209#action_12639209 ]
Eelco Hillenius commented on WICKET-1868:
-----------------------------------------
before blindly rolling back, can you at least tell me what you think is broken about them? It actually fixed quite a large problem for us that's been around even since when you worked for us, all tests passed and I haven't seen any issues with them anymore on our live site. It is quite possible that I missed something, but just rolling back without saying anything else about it isn't very helpful.
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius resolved WICKET-1868.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.4-M4
1.3.5
fixed in 1.3.x branch and trunk
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reopened WICKET-1868:
-----------------------------------
this change broke all resource lookups. i unrolled it from svn. make sure you run the tests when you checkin.
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645419#action_12645419 ]
Eelco Hillenius commented on WICKET-1868:
-----------------------------------------
Nope. I can try this weekend.
Eelco
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.6, 1.4-RC2
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639208#action_12639208 ]
Eelco Hillenius commented on WICKET-1868:
-----------------------------------------
I ran all the tests!!!!!!!!!!!! they passed
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645418#action_12645418 ]
Igor Vaynberg commented on WICKET-1868:
---------------------------------------
any news?
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.6, 1.4-RC2
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1868:
----------------------------------
Attachment: test.txt
tests failure log
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
> Attachments: test.txt
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1868) i18n package resource resolving
depends too much on available locale
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639217#action_12639217 ]
Igor Vaynberg commented on WICKET-1868:
---------------------------------------
when i updated this morning and ran our app none of the resources were resolving.
i then ran wicket tests and there were 26 failures (in resource related classes) and 20 errors because markup did not match since resources were not being looked up.
i traced the problem to resourcenameiterator, basically next() was no longer returning the full path to the resource. so instead of /foo/bar/Baz_en_us it was returning .en_us and thus the property factory could not load any property files.
i looked at svn history for resourcenameiterator and unrolled your last patch...all tests (with the exception of the one you modified) passed, so i unrolled the change.
so nothing was done blindly.
i did not have time to go and look at what exactly was broken, especially since martijn wants to build 1.3.5 today/tomorrow.
nothing was lost, the patches are still in svn tab of this issue so they can be easily reapplied...
> i18n package resource resolving depends too much on available locale
> --------------------------------------------------------------------
>
> Key: WICKET-1868
> URL: https://issues.apache.org/jira/browse/WICKET-1868
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Eelco Hillenius
> Assignee: Eelco Hillenius
> Fix For: 1.3.5, 1.4-M4
>
>
> Instead of just depending on the session's locale, our i18n resolving algorithm should look at the form of the file names as well. For instance, if we get a request for /web/resources/foo.Bar/test_en_US.css, it should recognize that test is the base form, and try en and en_US on top of that, regardless of the locale that is was set in the session.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.