You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/28 18:43:14 UTC
[GitHub] [apisix-helm-chart] Junnplus opened a new pull request #27: add apisix-dashboard helm chart
Junnplus opened a new pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r568582144
##########
File path: README.md
##########
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
It's better to add links for these two charts in the README.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus commented on a change in pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
Junnplus commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r567850539
##########
File path: README.md
##########
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
This md move to `charts/apisix`.
see https://github.com/apache/apisix-helm-chart/pull/27/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus commented on a change in pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
Junnplus commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r568276235
##########
File path: README.md
##########
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
see https://github.com/apache/apisix-helm-chart/pull/27/files#diff-bac1d31fa0f27c7026dcebb6994af021495e330e6fe54545d44b23937fb04e7cR20
##########
File path: README.md
##########
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
> It's better to add links for these two charts in the README.
Appended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] nic-chen commented on a change in pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r567847670
##########
File path: charts/apisix-dashboard/templates/deployment.yaml
##########
@@ -0,0 +1,86 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: {{ include "apisix-dashboard.fullname" . }}
+ labels:
+ {{- include "apisix-dashboard.labels" . | nindent 4 }}
+spec:
+ {{- if not .Values.autoscaling.enabled }}
+ replicas: {{ .Values.replicaCount }}
+ {{- end }}
+ selector:
+ matchLabels:
+ {{- include "apisix-dashboard.selectorLabels" . | nindent 6 }}
+ template:
+ metadata:
+ annotations:
+ checksum/config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
+ {{- with .Values.podAnnotations }}
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+ labels:
+ {{- include "apisix-dashboard.selectorLabels" . | nindent 8 }}
+ spec:
+ {{- with .Values.imagePullSecrets }}
+ imagePullSecrets:
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+ serviceAccountName: {{ include "apisix-dashboard.serviceAccountName" . }}
+ securityContext:
+ {{- toYaml .Values.podSecurityContext | nindent 8 }}
+ containers:
+ - name: {{ .Chart.Name }}
+ securityContext:
+ {{- toYaml .Values.securityContext | nindent 12 }}
+ image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
+ imagePullPolicy: {{ .Values.image.pullPolicy }}
+ ports:
+ - name: http
+ containerPort: {{ .Values.config.conf.listen.port }}
+ protocol: TCP
+ livenessProbe:
+ httpGet:
+ path: /
+ port: http
+ readinessProbe:
+ httpGet:
+ path: /
Review comment:
ditto
##########
File path: charts/apisix-dashboard/templates/configmap.yaml
##########
@@ -0,0 +1,55 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: {{ include "apisix-dashboard.fullname" . }}
+ labels:
+ {{- include "apisix-dashboard.labels" . | nindent 4 }}
+data:
+ conf.yaml: |-
+ {{- with .Values.config.conf }}
+ conf:
+ listen:
+ host: {{ .listen.host }}
+ port: {{ .listen.port }}
+ {{- with .etcd }}
+ etcd:
Review comment:
missing username and password for ETCD
##########
File path: charts/apisix-dashboard/templates/deployment.yaml
##########
@@ -0,0 +1,86 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: {{ include "apisix-dashboard.fullname" . }}
+ labels:
+ {{- include "apisix-dashboard.labels" . | nindent 4 }}
+spec:
+ {{- if not .Values.autoscaling.enabled }}
+ replicas: {{ .Values.replicaCount }}
+ {{- end }}
+ selector:
+ matchLabels:
+ {{- include "apisix-dashboard.selectorLabels" . | nindent 6 }}
+ template:
+ metadata:
+ annotations:
+ checksum/config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
+ {{- with .Values.podAnnotations }}
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+ labels:
+ {{- include "apisix-dashboard.selectorLabels" . | nindent 8 }}
+ spec:
+ {{- with .Values.imagePullSecrets }}
+ imagePullSecrets:
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+ serviceAccountName: {{ include "apisix-dashboard.serviceAccountName" . }}
+ securityContext:
+ {{- toYaml .Values.podSecurityContext | nindent 8 }}
+ containers:
+ - name: {{ .Chart.Name }}
+ securityContext:
+ {{- toYaml .Values.securityContext | nindent 12 }}
+ image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
+ imagePullPolicy: {{ .Values.image.pullPolicy }}
+ ports:
+ - name: http
+ containerPort: {{ .Values.config.conf.listen.port }}
+ protocol: TCP
+ livenessProbe:
+ httpGet:
+ path: /
Review comment:
it should be `/ping`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus commented on a change in pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
Junnplus commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r568679657
##########
File path: README.md
##########
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
> It's better to add links for these two charts in the README.
Appended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r568253049
##########
File path: README.md
##########
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
It's also required for dashboard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r568252751
##########
File path: README.md
##########
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
Even so, link is necessary.
##########
File path: README.md
##########
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
It's also required for dashboard.
##########
File path: README.md
##########
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
It's better to add links for these two charts in the README.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r568252751
##########
File path: README.md
##########
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
Even so, link is necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r567835088
##########
File path: README.md
##########
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
Why removing these descriptions?
##########
File path: charts/apisix-dashboard/templates/configmap.yaml
##########
@@ -0,0 +1,55 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+apiVersion: v1
Review comment:
@nic-chen Please take a look at this file, it's the template of apisix-dashboard's configuration file.
##########
File path: charts/apisix-dashboard/templates/deployment.yaml
##########
@@ -0,0 +1,86 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: {{ include "apisix-dashboard.fullname" . }}
+ labels:
+ {{- include "apisix-dashboard.labels" . | nindent 4 }}
+spec:
+ {{- if not .Values.autoscaling.enabled }}
+ replicas: {{ .Values.replicaCount }}
+ {{- end }}
+ selector:
+ matchLabels:
+ {{- include "apisix-dashboard.selectorLabels" . | nindent 6 }}
+ template:
+ metadata:
+ annotations:
+ checksum/config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
+ {{- with .Values.podAnnotations }}
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+ labels:
+ {{- include "apisix-dashboard.selectorLabels" . | nindent 8 }}
+ spec:
+ {{- with .Values.imagePullSecrets }}
+ imagePullSecrets:
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+ serviceAccountName: {{ include "apisix-dashboard.serviceAccountName" . }}
+ securityContext:
+ {{- toYaml .Values.podSecurityContext | nindent 8 }}
+ containers:
+ - name: {{ .Chart.Name }}
+ securityContext:
+ {{- toYaml .Values.securityContext | nindent 12 }}
+ image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
+ imagePullPolicy: {{ .Values.image.pullPolicy }}
+ ports:
+ - name: http
+ containerPort: {{ .Values.config.conf.listen.port }}
+ protocol: TCP
+ livenessProbe:
+ httpGet:
+ path: /
Review comment:
@nic-chen Also check it out, i'm not sure whether manager api has the dedicated health check API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#issuecomment-772137435
LGTM from my side.
@gxthrj @nic-chen Need your double check :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus commented on a change in pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
Junnplus commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r568276235
##########
File path: README.md
##########
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
see https://github.com/apache/apisix-helm-chart/pull/27/files#diff-bac1d31fa0f27c7026dcebb6994af021495e330e6fe54545d44b23937fb04e7cR20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers merged pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] membphis commented on pull request #27: add apisix-dashboard helm chart
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#issuecomment-770779403
ping @tokers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org