[GitHub] graceguo-supercat commented on a change in pull request #6617: #6588 Clear all other query tabs

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #6617: #6588 Clear all other query tabs
URL: https://github.com/apache/incubator-superset/pull/6617#discussion_r246127174
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/TabbedSqlEditors.jsx
 ##########
 @@ -197,6 +201,12 @@ class TabbedSqlEditors extends React.PureComponent {
               </div>
               {this.state.hideLeftBar ? t('Expand tool bar') : t('Hide tool bar')}
             </MenuItem>
+            <MenuItem eventKey="4" onClick={this.removeAllOtherQueryEditors.bind(this, qe)}>
 
 Review comment:
   i like this feature, but in most cases we don't bind event handler in render function. see explanation and samples here: https://medium.freecodecamp.org/the-best-way-to-bind-event-handlers-in-react-282db2cf1530. Bind in constructor() is pretty often in Superset code base.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org