[GitHub] [zeppelin] felixcheung commented on a change in pull request #3346: [ZEPPELIN-4066]. Introduce ProcessLauncher to encapsulate process launch

[GitBox <gi...@apache.org>]

felixcheung commented on a change in pull request #3346: [ZEPPELIN-4066]. Introduce ProcessLauncher to encapsulate process launch
URL: https://github.com/apache/zeppelin/pull/3346#discussion_r273781041
 
 

 ##########
 File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterManagedProcess.java
 ##########
 @@ -171,38 +140,20 @@ public Void call(RemoteInterpreterService.Client client) throws Exception {
           }
         });
       } catch (Exception e) {
-        logger.warn("ignore the exception when shutting down");
+        LOGGER.warn("ignore the exception when shutting down");
 
 Review comment:
   I think we should still log the error LOGGER.warn("", e)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services