[jira] [Reopened] (ZOOKEEPER-1411) Consolidate membership management, distinguish between static and dynamic configuration parameters

["Michi Mutsuzaki (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michi Mutsuzaki reopened ZOOKEEPER-1411:
----------------------------------------


It looks like this patch broke ZooKeeper-trunk-ibm6.

https://builds.apache.org/job/ZooKeeper-trunk-ibm6/122/testReport/org.apache.zookeeper.server.util/DynamicConfigBCTest/dynamicConfigBackwardCompatibilityTest/

This line is throwing an exception:

{noformat}
zkProp.entrySet().contains("dynamicConfigFile")
{noformat}

To avoid dealing with hashtable, we can do something like this:

{noformat}
zkProp.getProperty("dynamicConfigFile") != null
{noformat}

(I'm assuming the original patch meant to call containsKey() instead of contains())
                
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1411
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: server
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver11.patch, ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it. 
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers(). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira