You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/02/09 10:23:39 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #8323: [Fix-8316][Master] Stop dependent node error

caishunfeng commented on a change in pull request #8323:
URL: https://github.com/apache/dolphinscheduler/pull/8323#discussion_r802506762



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/queue/TaskResponsePersistThread.java
##########
@@ -159,7 +159,11 @@ private boolean persist(TaskResponseEvent taskResponseEvent) {
                     }
                 }
                 TaskKillAckCommand taskKillAckCommand = new TaskKillAckCommand(ExecutionStatus.SUCCESS.getCode(), taskResponseEvent.getTaskInstanceId());

Review comment:
       It's better to check channel first, it is no need to create `taskKillAckCommand` when channel is null.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org