You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2026/06/01 16:46:13 UTC

(superset) 01/01: Merge remote-tracking branch 'origin/master' into claude/subdirectory-helpers-tdd

This is an automated email from the ASF dual-hosted git repository.

sadpandajoe pushed a commit to branch claude/subdirectory-helpers-tdd
in repository https://gitbox.apache.org/repos/asf/superset.git

commit d0d9fb257bf5d252e0309cee9434ceeb676caa8a
Merge: 5fee21b5090 a33fcb0eddc
Author: Joe Li <jo...@preset.io>
AuthorDate: Mon Jun 1 09:45:52 2026 -0700

    Merge remote-tracking branch 'origin/master' into claude/subdirectory-helpers-tdd
    
    # Conflicts:
    #       superset-frontend/playwright/pages/DashboardPage.ts

 .github/workflows/bashlib.sh                       |  16 +-
 .github/workflows/superset-e2e.yml                 |   5 +
 .github/workflows/superset-playwright.yml          |  20 ++
 .../pythonpath_dev/superset_config_docker_light.py |  31 ++
 superset-frontend/playwright.config.ts             |  24 ++
 .../playwright/components/core/EditableTabs.ts     |  18 +-
 .../components/modals/EditDatasetModal.ts          |  17 +
 .../playwright/embedded-app/index.html             |  95 ++++++
 .../playwright/helpers/api/dashboard.ts            |  50 ++-
 .../playwright/helpers/api/embedded.ts             | 133 ++++++++
 .../playwright/helpers/api/requests.ts             | 112 +++++--
 superset-frontend/playwright/helpers/navigation.ts |  57 ++++
 .../playwright/pages/ChartCreationPage.ts          |   3 +-
 .../playwright/pages/ChartListPage.ts              |   5 +-
 .../playwright/pages/CreateDatasetPage.ts          |   3 +-
 .../playwright/pages/DashboardListPage.ts          |   3 +-
 .../playwright/pages/DashboardPage.ts              |   5 +-
 .../playwright/pages/DatasetListPage.ts            |   3 +-
 superset-frontend/playwright/pages/EmbeddedPage.ts | 172 ++++++++++
 superset-frontend/playwright/pages/SqlLabPage.ts   |  37 ++-
 .../tests/embedded/embedded-dashboard.spec.ts      | 362 +++++++++++++++++++++
 superset-frontend/playwright/utils/constants.ts    |  13 +
 .../AddDataset/DatasetPanel/DatasetPanel.test.tsx  |  23 ++
 .../AddDataset/DatasetPanel/DatasetPanel.tsx       |   2 +-
 tests/integration_tests/superset_test_config.py    |   1 +
 25 files changed, 1141 insertions(+), 69 deletions(-)

diff --cc superset-frontend/playwright/pages/DashboardPage.ts
index 075c4f19a4f,a61ff3415c1..9b81d493d94
--- a/superset-frontend/playwright/pages/DashboardPage.ts
+++ b/superset-frontend/playwright/pages/DashboardPage.ts
@@@ -43,7 -44,7 +44,7 @@@ export class DashboardPage 
     * @param slug - The dashboard slug (e.g., 'world_health')
     */
    async gotoBySlug(slug: string): Promise<void> {
-     await this.page.goto(`dashboard/${slug}/`);
 -    await gotoWithRetry(this.page, `superset/dashboard/${slug}/`);
++    await gotoWithRetry(this.page, `dashboard/${slug}/`);
    }
  
    /**
@@@ -51,7 -52,7 +52,7 @@@
     * @param id - The dashboard ID
     */
    async gotoById(id: number): Promise<void> {
-     await this.page.goto(`dashboard/${id}/`);
 -    await gotoWithRetry(this.page, `superset/dashboard/${id}/`);
++    await gotoWithRetry(this.page, `dashboard/${id}/`);
    }
  
    /**