You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/17 20:14:45 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #13186: fix: SqlEditor_spec tests
michael-s-molina opened a new pull request #13186:
URL: https://github.com/apache/superset/pull/13186
### SUMMARY
Fixes SqlEditor_spec tests:
- Waits for elements to be rendered
- Removes fetch warnings with `fetch-mock`
- Provides required prop `addDangerToast`
### TEST PLAN
1 - Execute tests in spec/javascripts/sqllab/SqlEditor_spec
2 - All tests should pass
@rusackas
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #13186: fix: SqlEditor_spec tests
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #13186:
URL: https://github.com/apache/superset/pull/13186#discussion_r579162150
##########
File path: superset-frontend/spec/javascripts/sqllab/SqlEditor_spec.jsx
##########
@@ -72,22 +78,26 @@ describe('SqlEditor', () => {
},
);
- it('render a SqlEditorLeftBar', () => {
+ it('render a SqlEditorLeftBar', async () => {
Review comment:
They don't work. I think they are really old tests. One of them is using setState but the component is a functional component now and it seems that the height logic being tested is also different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13186: fix: SqlEditor_spec tests
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13186:
URL: https://github.com/apache/superset/pull/13186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #13186: fix: SqlEditor_spec tests
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #13186:
URL: https://github.com/apache/superset/pull/13186#discussion_r578655983
##########
File path: superset-frontend/spec/javascripts/sqllab/SqlEditor_spec.jsx
##########
@@ -72,22 +78,26 @@ describe('SqlEditor', () => {
},
);
- it('render a SqlEditorLeftBar', () => {
+ it('render a SqlEditorLeftBar', async () => {
Review comment:
I'm not sure some tests in this file were skipped in the first place, but I wonder if they work now :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #13186: fix: SqlEditor_spec tests
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #13186:
URL: https://github.com/apache/superset/pull/13186#issuecomment-781170480
@eschutho might want to take a gander at this one too :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org