[GitHub] [spark] maryannxue commented on a diff in pull request #38358: [SPARK-40588] FileFormatWriter materializes AQE plan before accessing outputOrdering

[GitBox <gi...@apache.org>]

maryannxue commented on code in PR #38358:
URL: https://github.com/apache/spark/pull/38358#discussion_r1003780647


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -221,6 +221,8 @@ case class AdaptiveSparkPlanExec(
       .map(_.toLong).filter(SQLExecution.getQueryExecution(_) eq context.qe)
   }
 
+  private[sql] lazy val finalPlan: SparkPlan = getFinalPhysicalPlan()

Review Comment:
   can we just change access of `getFinalPhysicalPlan()` to `private[sql]` instead? I don't think we need a duplicate of `executedPlan` in this class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org