You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2013/01/22 19:50:02 UTC
[Bug 54469] New: IPMT, PPMT financial functions implemented and
integrated in POI v3.8
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Bug ID: 54469
Summary: IPMT, PPMT financial functions implemented and
integrated in POI v3.8
Product: POI
Version: 3.8-dev
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: POI Overall
Assignee: dev@poi.apache.org
Reporter: micharg@gmail.com
Classification: Unclassified
I have extended POI to contain the EXCEL fincancial functions
IPMT, PPMT. Just diff and integrate the differences... is this the right place
for posting the patched POI?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Nick Burch <ap...@gagravarr.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |NEEDINFO
--- Comment #9 from Nick Burch <ap...@gagravarr.org> ---
The patch doesn't include any unit tests, so I tried adding one myself by
putting in a few sample formulas using the functions in FormulaEvalTestData.xls
However, when I do that, the unit test fails as POI is unable to correctly
evaluate the PPMT function to give the same result as Excel
Could you please look into this, and produce either an updated patch that fixes
it, or suggest an alternate test for it?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
--- Comment #8 from Nick Burch <ap...@gagravarr.org> ---
Created attachment 29949
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29949&action=edit
Updated FormulaEvalTestData
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
--- Comment #12 from Nick Burch <ap...@gagravarr.org> ---
If you grab the POI sourcecode, you'll find the unit test in there already. If
you replace FormulaEvalTestData in test-documents with the one attached, and
re-run the test with your patch applied you'll see the failure
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] IPMT, PPMT financial functions implemented and
integrated in POI v3.8
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
--- Comment #1 from Mike Argyriou <mi...@gmail.com> ---
Because the patched POI is too large to attach it here (about 100MB) you can
download it from http://uploaded.net/file/ulq8cj21
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
--- Comment #13 from Mike Argyriou <mi...@gmail.com> ---
Thank you for your immediate answer! I will take care of it asap...
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Mike Argyriou <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Mike Argyriou <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |NEEDINFO
Severity|normal |enhancement
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] IPMT, PPMT financial functions implemented and
integrated in POI v3.8
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Nick Burch <ap...@gagravarr.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #2 from Nick Burch <ap...@gagravarr.org> ---
The patch should normally be just a few kb in size, maybe a few hundred kb with
test files. Are you able to check that your patch only has these, and not
something else by mistake? (100mb is a pretty huge patch!)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #18 from Dominik Stadler <do...@gmx.at> ---
needs info based on previous comment
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
--- Comment #16 from Mike Argyriou <mi...@gmail.com> ---
I have uploaded an updated patch and new convinient manual tests (should not be
included in the POI trunk repository)..
Just read the attachments comments..in the nutshell please increase the decimal
digitis on the test-xls.
Thanks you
Mike
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Mike Argyriou <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Mike Argyriou <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Mike Argyriou <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Mike Argyriou <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
--- Comment #11 from Mike Argyriou <mi...@gmail.com> ---
Nick can you attach the unit tests please so I can check why they fail in order
the patch to be integrated to POI? Thank u!
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Mike Argyriou <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
--- Comment #7 from Mike Argyriou <mi...@gmail.com> ---
Is there any feedback for this patch?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Mike Argyriou <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29887|0 |1
is obsolete| |
--- Comment #14 from Mike Argyriou <mi...@gmail.com> ---
Created attachment 29986
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29986&action=edit
updated patch
Updated patch....some minor fixes and some typos...
The tests should pass if you set the formatting of the cells in
FormulaEvalTestData.xls to more decimal digits... the IPMT test fails because
the cell D764 with value 0.01 has two decimals digits...the test returns the
value ~0.005 and it fails..increase the cell's number of decimal digits to
(e.g.) 4...
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Yegor Kozlov <ye...@dinom.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |NEW
--- Comment #17 from Yegor Kozlov <ye...@dinom.ru> ---
Partially applied in r1451886 with some tweaks.
Your implementation of PPMT is buggy. If I run PPMT_test I'm getting this:
ppmt=-121.95920277082378 [should be equal to -350.99]
The value -350.99 is correct, I confirmed it in Excel.
Interestingly that two test cases from
http://office.microsoft.com/en-001/excel-help/ppmt-function-HP010342774.aspx
pass.
Please fix PPMT , I guess it a math error and should be easy to detect and fix.
Regards,
Yegor
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
--- Comment #10 from Mike Argyriou <mi...@gmail.com> ---
Can you attach the unit test?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] IPMT, PPMT financial functions implemented and
integrated in POI v3.8
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
--- Comment #3 from Mike Argyriou <mi...@gmail.com> ---
Actually I have uploaded all the POI project patched with the new code. Should
I upload only the diffs?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
--- Comment #6 from Mike Argyriou <mi...@gmail.com> ---
Created attachment 29887
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29887&action=edit
diff patch file created from "ant -f patch.xml" on the latest svn POI
repository
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] IPMT, PPMT financial functions implemented and
integrated in POI v3.8
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
--- Comment #4 from Yegor Kozlov <ye...@dinom.ru> ---
yes, you should upload only the diffs. See
http://poi.apache.org/guidelines.html#SubmittingPatches
(In reply to comment #3)
> Actually I have uploaded all the POI project patched with the new code.
> Should I upload only the diffs?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
Mike Argyriou <mi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|3.8-dev |4.0-dev
Summary|IPMT, PPMT financial |[PATCH] IPMT, PPMT
|functions implemented and |financial functions
|integrated in POI v3.8 |implemented and integrated
| |in latest POI
--- Comment #5 from Mike Argyriou <mi...@gmail.com> ---
I have downloaded the latest POI from git, integrated/created the IPMT,PPMT
functions and created the patched using "ant -f patch.xml". I have attached the
path created by Ant.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54469] [PATCH] IPMT, PPMT financial functions implemented and
integrated in latest POI
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54469
--- Comment #15 from Mike Argyriou <mi...@gmail.com> ---
Created attachment 29987
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29987&action=edit
Main classes for testing ipmt, pmt, etc
The attachnent contains Main-classes which test the financial functions...check
the code please...
place all the *.java in trunk/src/java
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org